Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jdk21 to build health report #702

Merged
merged 1 commit into from
May 26, 2023

Conversation

adamfarley
Copy link
Contributor

No description provided.

@adamfarley adamfarley self-assigned this May 16, 2023
@github-actions github-actions bot added the code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts label May 16, 2023
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,20"

@adamfarley adamfarley force-pushed the add_jdk21_to_build_health_report branch from c94a537 to e8fda19 Compare May 16, 2023 11:13
@adamfarley
Copy link
Contributor Author

adamfarley commented May 16, 2023

Test run here: https://ci.adoptium.net/job/nightlyBuildAndTestStats_temurin/1059/

EDIT: Failed because the call to "https://api.adoptium.net/v3/assets/feature_releases/21/ea" failed due to there being nothing there. Possibly because we've never released jdk21. I wonder how we've fetched this data for previous jdk versions prior to their first release. Will ask on #build slack channel.

Update: Known issue. Have reverted the healthcheck report generator job to use the master branch again, and I've asked John for insights on Slack:

Update: Solved! Good job John. Re-ran the health check job here and it successfully generated jdk21 output here. So we're ready for reviews.

@adamfarley adamfarley changed the title Add jdk21 to build health report WIP: Add jdk21 to build health report May 16, 2023
@karianna karianna marked this pull request as draft May 17, 2023 02:06
@adamfarley adamfarley changed the title WIP: Add jdk21 to build health report Add jdk21 to build health report May 17, 2023
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure that this part of the process is documented in https://github.com/adoptium/temurin-build/blob/master/RELEASING.md#openjdk-new-major-release-process - probably using a link to this PR as an example.

@adamfarley
Copy link
Contributor Author

Can we make sure that this part of the process is documented in https://github.com/adoptium/temurin-build/blob/master/RELEASING.md#openjdk-new-major-release-process - probably using a link to this PR as an example.

Sure. I'll hold off until John Oliver has replied to this Slack message with the details of his changes to api.adoptium.net.

@sxa
Copy link
Member

sxa commented May 17, 2023

From the thread it seems that https://github.com/adoptium/api.adoptium.net/blob/bda17356dae38e4a36a2aa2aef9bec3b5e9e4275/adoptium-models-parent/adoptium-api-v3-models/src/main/kotlin/net/adoptium/api/v3/models/Versions.kt#L5 needs to be updated too so that should be done and added to the docs as well (The immediate fix that was applied to resolve this was to override the java LATEST_JAVA_VERSION property in the API instead of updating that file)

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sxa
Copy link
Member

sxa commented May 17, 2023

API change PR: adoptium/api.adoptium.net#578

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis that the documentation gets done, as that will need to be in a different repository anyway so will not be part of this PR.

@adamfarley adamfarley marked this pull request as ready for review May 18, 2023 12:01
@gdams gdams merged commit ed05e6a into adoptium:master May 26, 2023
@adamfarley
Copy link
Contributor Author

Note: The docs change mentioned above was carried out here: adoptium/temurin-build#3360

luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants