Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: groovy linter warnings #428

Open
zdtsw opened this issue Oct 4, 2022 · 1 comment
Open

Fix: groovy linter warnings #428

zdtsw opened this issue Oct 4, 2022 · 1 comment

Comments

@zdtsw
Copy link
Contributor

zdtsw commented Oct 4, 2022

To fix all the linter Warnings and preferable Info from GH action super-linter
Goal: without any codenarc rule excluded , we should keep

┌─────────┬───────────┬─────────────┐
│ (index) │ Severity  │ Total found │
├─────────┼───────────┼─────────────┤
│    0    │  'Error'  │      0      │
│    1    │ 'Warning' │      0      │
│    2    │  'Info'   │      0      │
└─────────┴───────────┴─────────────┘

example run: https://github.com/adoptium/ci-jenkins-pipelines/actions/runs/3177396948/jobs/5177786644

Related: #427 and #425

@zdtsw
Copy link
Contributor Author

zdtsw commented Oct 5, 2022

Below are the warnings that cannot be auto-fixed:
we might need to have a discussion to see if exclude or fix them:

  • LineLength easy but a lot
  • ExplicitCallToEqualsMethod easy
  • NestedBlockDepth difficult: we have several in the depth of 11 and 12
  • ThrowExceptionFromFinallyBlock difficult and need review
  • PrivateFieldCouldBeFinal need review each
  • ReturnNullFromCatchBlock difficult and need review each
  • DuplicateMapLiteral unsure
  • ExplicitCallToGetAtMethod need review each
  • Instanceof easy
  • ParameterCount difficult
  • ParameterName need review each to fix
  • FieldName need review to fix
  • SerializableClassMustDefineSerialVersionUID difficult
  • BuilderMethodWithSideEffects need review each to fix
  • ExplicitCallToGetAtMethod easy
  • ExplicitCallToMinusMethod easy
  • ExplicitHashMapInstantiation easy
  • FactoryMethodName need review each to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant