-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update top level README.md so it is more consumable for new users #1048
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
8a39bbc
to
acf2235
Compare
0e54eb2
to
ba59151
Compare
ba59151
to
f936745
Compare
f936745
to
a834476
Compare
More 'TODO:' / "Memo to self" items:
Docker handling is in the queue phase:
and the non-docker situation is at
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I like that its been split like this :)
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
7a0103c
to
b5c58c4
Compare
(Force push done via the UI to in order to rebase, and re-trigger linter checks) |
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Various changes:
Focus on the different build pipeline types so they can be understood, and include:
Move the details of the configuration files into a separate readme file
Collapse the section on the metadata generation (Should that be moved elsewhere? It's fully duplicated in the temurin-build README.md although with some formatting changes (e.g. that one still references "openjdk-build" - the repo had those references updated in https://github.com/adoptium/ci-jenkins-pipelines/pull/285/files). Differences here:
diff.txt
Add links to the markdown files in the docs directory (Maybe they need a once-over too to verify that the information is still up to date. Some of the diagrams could potentially be inlined into the top level README)
Further items to be clarified via the
TODO
items in this PR.Note: The README.md in the configuration directory has been forked from the top level README.md using the process from https://stackoverflow.com/questions/1043388/record-file-copy-operation-with-git/46484848#46484848 to preserve the "forked" file's history.
For discussion: