Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update top level README.md so it is more consumable for new users #1048

Merged
merged 10 commits into from
Nov 5, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Jun 19, 2024

Various changes:

  • Focus on the different build pipeline types so they can be understood, and include:

    • How they are structured in jenkins
    • How they are triggered
    • Which pipelines are related to each one
  • Move the details of the configuration files into a separate readme file

  • Collapse the section on the metadata generation (Should that be moved elsewhere? It's fully duplicated in the temurin-build README.md although with some formatting changes (e.g. that one still references "openjdk-build" - the repo had those references updated in https://github.com/adoptium/ci-jenkins-pipelines/pull/285/files). Differences here:
    diff.txt

  • Add links to the markdown files in the docs directory (Maybe they need a once-over too to verify that the information is still up to date. Some of the diagrams could potentially be inlined into the top level README)

Further items to be clarified via the TODO items in this PR.
Note: The README.md in the configuration directory has been forked from the top level README.md using the process from https://stackoverflow.com/questions/1043388/record-file-copy-operation-with-git/46484848#46484848 to preserve the "forked" file's history.

For discussion:

  • What naming convention should we use for the top level pipelines (openjdkXX-pipelines) vs individual build pipelines (jdkXX-linux-aarch64-temurin)
  • Add a small diagram of the folder structure?
  • Add evaluation jobs to the table that the bottom? Plus JDk22/23? (Also RISC-V needs a bit of work now it's production)

@sxa sxa self-assigned this Jun 19, 2024
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@github-actions github-actions bot added documentation jenkins-pipeline generation Issues that provide enhancements or fixes to the job generators labels Jun 19, 2024
@sxa sxa force-pushed the pipeline_doc_updates branch 4 times, most recently from 8a39bbc to acf2235 Compare June 20, 2024 10:58
@sxa sxa force-pushed the pipeline_doc_updates branch 2 times, most recently from 0e54eb2 to ba59151 Compare June 20, 2024 11:01
@sxa
Copy link
Member Author

sxa commented Sep 3, 2024

More 'TODO:' / "Memo to self" items:

Docker handling is in the queue phase:


and the non-docker situation is at

build() invokes buildScripts() either directly or under a context.docker.build(). On Windows, this causes a problem as there is a context('eclipse-codesign') within buildScripts() which cannot handle being run in a docker context.
formMetadata/writeMetadata notes

@sxa sxa requested a review from steelhead31 November 4, 2024 13:22
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like that its been split like this :)

@sxa
Copy link
Member Author

sxa commented Nov 4, 2024

(Force push done via the UI to in order to rebase, and re-trigger linter checks)
Noting that my earlier comments about things that should be explained will be a lot clearer with the eye catchers (openjdk_build_pipeline:) in #1117

@sxa sxa marked this pull request as ready for review November 4, 2024 13:56
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
@sxa sxa merged commit bb6714e into adoptium:master Nov 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch documentation generation Issues that provide enhancements or fixes to the job generators jenkins-pipeline linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants