Mark node offline if cannot delete workspace #5636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related: adoptium#5358 and infrastructure/issues/9874 Signed-off-by: Lan Xia <[email protected]>
|
Grinder - We do not have a machine for testing |
LongyuZhang
approved these changes
Sep 19, 2024
|
The change looks fine, just wondering if there is a hint about the error for the infra when the machine is offline? |
|
A message will be posted on the #rt-jenkins channel. For example link The same message will be added on the Jenkins machine page. |
JasonFengJ9
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #5358 and infrastructure/issues/9874