Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logic for jdk-version specific suites #5575

Open
judovana opened this issue Sep 10, 2024 · 5 comments
Open

add logic for jdk-version specific suites #5575

judovana opened this issue Sep 10, 2024 · 5 comments

Comments

@judovana
Copy link
Contributor

judovana commented Sep 10, 2024

#5553 (comment) have reminded me old issue, where some external tests, eg jacoco, works fine with 8-17 but do not work with jdk21

Unluckily, current logic to clone and checkout is in https://github.com/adoptium/aqa-tests/blob/master/external/jacoco/test.properties

So I see several options with many pros and cons:

  • narrow the checkout in test.sh ( I do not like this)
  • have duplicated testfolder (so jacoco target would be limited for jdk21 onwards, and will have updated tag, and new jacoco17 wold be limited to 17 and older)
  • create flexible checkout logic in properties file similar to what I did for os-based properties (I'm not sure I like this)
    • tag_version -> tag(7|8)_version and tag(21|22)_version ....
    • this is less expendable to other non-external test

This will be quite a precedent for other - at least external - tests

Many others maybe have to be simply disabled for older/newer jdks, but that is easily done in playlists?

@smlambert
Copy link
Contributor

Thanks for raising this issue @judovana. Before any option is chosen, it will be good to create a table of external apps, their versions and which ones work with which Java version. That will be useful to visualize and help inform the best way forward.

@judovana
Copy link
Contributor Author

Thanks for raising this issue @judovana. Before any option is chosen, it will be good to create a table of external apps, their versions and which ones work with which Java version. That will be useful to visualize and help inform the best way forward.

thats terrible task.... I would much rather go one by one:(

@judovana
Copy link
Contributor Author

judovana commented Sep 10, 2024

But yah, would try to do that. You are rigth that it is moreover necessary

@smlambert
Copy link
Contributor

But yah, would try to do that. You are rigth that it is moreover necessary

We can work on it together :)

@judovana
Copy link
Contributor Author

I will wait for #5553 to merge. Once I will be doing such a matrix, I will include multi-base-images to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants