Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement logic to find Java version in JavaVersion.java #114

Open
Mesbah-Alam opened this issue Apr 22, 2021 · 1 comment
Open

Reimplement logic to find Java version in JavaVersion.java #114

Mesbah-Alam opened this issue Apr 22, 2021 · 1 comment
Labels
enhancement

Comments

@Mesbah-Alam
Copy link
Contributor

We should remove the version check altogether and update the logic of figuring out various Java versions in JavaVersion.java to depend on Java system properties instead of parsing java -version output.
@Mesbah-Alam Mesbah-Alam mentioned this issue Apr 22, 2021
Merged
@Mesbah-Alam Mesbah-Alam mentioned this issue Jul 9, 2021
Merged
@ultramancoder
Copy link

Hi! Trying on work on this task but I could not find any tests to verify the changes are correct. Any suggestions on how I should test my changes or should I open a PR directly for review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mesbah-Alam @ultramancoder