Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failing test case for autotracking of derived state #495

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add failing test case for autotracking of derived state #495

wants to merge 1 commit into from

Conversation

andreyfel
Copy link
Contributor

No description provided.

@andreyfel andreyfel mentioned this pull request Jun 3, 2020
Open
@andreyfel andreyfel force-pushed the illustrate-autotracking-bug branch 2 times, most recently from ea5320a to 95867a1 Compare June 3, 2020 13:47
snewcomer
snewcomer reviewed Jun 3, 2020
View reviewed changes
tests/integration/misc-test.js Outdated
class MyModel {
isOptionOne = false;
isOptionTwo = false;
isOptionThree = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if you add @tracked to these properties?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed that.
It still can be reproduced with @tracked

@andreyfel andreyfel force-pushed the illustrate-autotracking-bug branch from 95867a1 to 3e26df0 Compare June 3, 2020 14:07
@snewcomer
Copy link
Collaborator

@andreyfel This looks like a tough one. When you explicitly set a value (isOptionTwo), we look to update the ERRORS. If the error looks like this - {isOptionSelected: Err} - then we can't delete it. Moreover, thinking about tracked-built-ins, I'm not seeing off hand how that would help either. We either push / remove an error explicitly in response to set.

Do you have any thoughts as to a solution here?

@andreyfel
Copy link
Contributor Author

You are right that just switching to tracked-built-ins won't help here.

One thought I have is to make ERRORS a getter vs a static property and calculate it based on CHANGES.

@snewcomer
Copy link
Collaborator

I'm only guessing after #509, this is still failing?

@andreyfel andreyfel force-pushed the illustrate-autotracking-bug branch from 3e26df0 to 68eafd2 Compare June 16, 2020 06:48
@andreyfel
Copy link
Contributor Author

Yep, still failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreyfel @snewcomer