Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_vpfiles() support reading remote files #544

Open
peterdesmet opened this issue Dec 13, 2022 · 3 comments
Open

read_vpfiles() support reading remote files #544

peterdesmet opened this issue Dec 13, 2022 · 3 comments
Labels
enhancement VPTS CSV Related to VPTS CSV format
Milestone

Comments

@peterdesmet
Copy link
Collaborator

Cf. how readr::read_csv() allows to read remote csv files, it would be useful that read_vpfiles() did the same. This especially useful to create reproducible examples:

library(bioRad)
read_vpfiles("https://aloft.s3-eu-west-1.amazonaws.com/baltrad/hdf5/bejab/2022/08/19/bejab_vp_20220819T235500Z_0x9.h5")
@bart1
Copy link
Collaborator

bart1 commented May 15, 2023

I have looked at some stage into this. Reading h5 files from remote is not easy. I would avoid going there. If you are referring to the csv it is indeed easily done without temporary files using vroom or readr (the former allows to modify the request using curl which can be useful for authentication).

@bart1
Copy link
Collaborator

bart1 commented May 15, 2023

I just saw your example was with an h5 file there fore my feedback

@peterdesmet
Copy link
Collaborator Author

I agree that reading csv files remotely is quite easy, can be implemented in read_vpts() (#551). That would help to write shorter reproducible examples. The typical workflow would still be to download first (#553) and read second.

@peterdesmet peterdesmet changed the title Support reading remote vp files read_vpfiles() support reading remote files May 15, 2023
@adokter adokter added this to the 1.0.0 milestone Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement VPTS CSV Related to VPTS CSV format
Projects
None yet
Development

No branches or pull requests

3 participants