Skip to content

Submitting PRs

Jump to bottom
Brandon Marshall edited this page Jun 23, 2023 · 1 revision

Please review the contributing doc before submitting a PR.

Approvals

  1. Every PR need at least one approver.
  2. Please add at least one person from the magma team as reviewer on your PR. You can also add the milo core team.
  3. Assign your PR to one person to test your feature.

Audits

  • Unit Tests are included for any new features and existing tests pass. We aim for 100% code coverage.
  • Performance: Performance must be considered. We aim for an upper-90s lighthouse score.
  • Linters: Your code should pass all linters.

Verification

Once the code has been approved, please notify the assignee that they can begin verification testing.

  • If the code won't affect the production site, it should have the "trivial" label and can skip verification.
  • Code has been tested by QE (if applicable) and PR has "verified".

Merging

Notify a bacom owner when the PR is ready to be merged.

Clone this wiki locally