Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Radio group value cleared on non-radio change events #5098

Open
1 task done
adixon-adobe opened this issue Feb 15, 2025 · 0 comments
Open
1 task done

[Bug]: Radio group value cleared on non-radio change events #5098

adixon-adobe opened this issue Feb 15, 2025 · 0 comments
Labels
bug Something isn't working needs jira ticket triage An issue needing triage

Comments

@adixon-adobe
Copy link
Collaborator

adixon-adobe commented Feb 15, 2025

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-radio-group

Expected behavior

If I have a picker or other menu within a radio group, selecting something in the menu should work properly.

Actual behavior

Selecting a menu item clears the radio group value.

Screenshots

No response

What browsers are you seeing the problem in?

Firefox, Chrome, Microsoft Edge, Safari

How can we reproduce this issue?

Check out https://studio.webcomponents.dev/edit/54bJFRBzLo2bNI5P23et/src/index.ts?p=stories

This appears to be the source of the bug -- we're still setting selected if the tag isn't a radio: https://github.com/adobe/spectrum-web-components/blob/main/packages/radio/src/RadioGroup.ts#L114

Sample code or abstract reproduction which illustrates the problem

No response

Severity

SEV 3

Logs taken while reproducing problem

I believe we can work around this by preventing the change event from the picker/menu from bubbling up to the radio group, so marking as a Sev 3.

@adixon-adobe adixon-adobe added bug Something isn't working needs jira ticket triage An issue needing triage labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs jira ticket triage An issue needing triage
Projects
None yet
Development

No branches or pull requests

1 participant