Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Coachmark step count is not localized #4780

Open
1 task done
mollydonohue opened this issue Sep 24, 2024 · 1 comment
Open
1 task done

[Bug]: Coachmark step count is not localized #4780

mollydonohue opened this issue Sep 24, 2024 · 1 comment

Comments

@mollydonohue
Copy link

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Coachmark

Expected behavior

In the Coachmark component the step count, for example "1 of 3" has hardcoded the "of" string. The expected behavior is that this string is localized, or is at least configurable so the client can pass in the string to use in this case.

Actual behavior

The "of" word is hardcoded.

Screenshots

issue-2
issue-3

What browsers are you seeing the problem in?

Chrome

How can we reproduce this issue?

Bug was discovered in a pre-release version so I can't share my own reproduction steps, as the feature has not been publicly released. But this surely reproduces anywhere Coachmark component is used.

  1. Change language to non-english
  2. Enter multi-step coachmark tour
    Code where this is hard-coded is here
    ${this.currentStep} of ${this.totalSteps}

Sample code or abstract reproduction which illustrates the problem

No response

Severity

SEV 3

Logs taken while reproducing problem

No response

@mollydonohue mollydonohue added bug Something isn't working needs jira ticket triage An issue needing triage labels Sep 24, 2024
@najikahalsema najikahalsema added I18n good first issue Good for newcomers Component: Coach Mark jira ticket created enhancement New feature or request and removed needs jira ticket bug Something isn't working labels Oct 8, 2024
@najikahalsema najikahalsema removed the triage An issue needing triage label Oct 16, 2024
@Rajdeepc
Copy link
Contributor

This will be taken in the broader work of adding i8n capabilities in the library. For the time being you can slot the translation via

<div slot="step-count">4 分の 1</div> 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants