Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][a11y]: Slider focus style should support forced-colors: active / WHCM #3328

Closed
1 task done
majornista opened this issue Jun 19, 2023 · 4 comments
Closed
1 task done
Labels
a11y Issues related to accessibility bug Something isn't working Component: Range Slider Component: Slider WHCM

Comments

@majornista
Copy link
Contributor

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Slider, SliderHandle

Expected behavior

Slider focused style should match Spectrum specification and the focus ring should render with forced-colors: active or windows high contrast mode. We should also use Highlight color appropriately for track, fill-color and focused state.

Spectrum

Spectrum Slider keyboard focused style

Spectrum with forced-colors: active / WHCM

Spectrum Slider keyboard focused style with forced-colors: active

Actual behavior

Slider uses an older version of the focused style and the focus ring is not visible in high contrast mode.

SWC

Spectrum Web Components Slider keyboard focused style

SWC with forced-colors: active / WHCM

Spectrum Web Components Slider keyboard focused style with forced-colors: active

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to '...'
  2. Click on '....'
  3. Scroll to '....'
  4. Check console
  5. See error

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@majornista majornista added bug Something isn't working Component: Slider a11y Issues related to accessibility WHCM Component: Range Slider triage An issue needing triage labels Jun 19, 2023
@Westbrook
Copy link
Contributor

@pfulton this appears to occur in the Spectrum CSS source, as well.

@Westbrook
Copy link
Contributor

@pfulton were yall able to capture this in Jira, or should I open an issue in GH to help yall along?

@pfulton
Copy link
Collaborator

pfulton commented Nov 3, 2023

Got it! PR is here and awaiting merge: adobe/spectrum-css#2217

@Westbrook
Copy link
Contributor

This was fixed along the way. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues related to accessibility bug Something isn't working Component: Range Slider Component: Slider WHCM
Projects
None yet
Development

No branches or pull requests

4 participants