Skip to content

Commit 67cf3ef

Browse files
test: unskip scroll tests
1 parent 7ec37a9 commit 67cf3ef

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

packages/tabs/test/tabs-overflow.test.ts

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,21 @@ the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTA
99
OF ANY KIND, either express or implied. See the License for the specific language
1010
governing permissions and limitations under the License.
1111
*/
12-
import '@spectrum-web-components/theme/sp-theme.js';
13-
import '@spectrum-web-components/theme/scale-medium.js';
14-
import '@spectrum-web-components/theme/theme-light.js';
15-
import '@spectrum-web-components/tabs/sp-tab.js';
16-
import '@spectrum-web-components/tabs/sp-tabs.js';
17-
import '@spectrum-web-components/tabs/sp-tab-panel.js';
18-
import '@spectrum-web-components/tabs/sp-tabs-overflow.js';
12+
import { ActionButton } from '@spectrum-web-components/action-button';
1913
import {
2014
calculateScrollTargetForLeftSide,
2115
calculateScrollTargetForRightSide,
2216
Tab,
2317
Tabs,
2418
TabsOverflow,
2519
} from '@spectrum-web-components/tabs';
26-
import { ActionButton } from '@spectrum-web-components/action-button';
20+
import '@spectrum-web-components/tabs/sp-tab-panel.js';
21+
import '@spectrum-web-components/tabs/sp-tab.js';
22+
import '@spectrum-web-components/tabs/sp-tabs-overflow.js';
23+
import '@spectrum-web-components/tabs/sp-tabs.js';
24+
import '@spectrum-web-components/theme/scale-medium.js';
25+
import '@spectrum-web-components/theme/sp-theme.js';
26+
import '@spectrum-web-components/theme/theme-light.js';
2727

2828
import { elementUpdated, expect, fixture, waitUntil } from '@open-wc/testing';
2929
import {
@@ -32,8 +32,8 @@ import {
3232
html,
3333
nothing,
3434
} from '@spectrum-web-components/base';
35+
import { sendKeys, setViewport } from '@web/test-runner-commands';
3536
import { repeat } from 'lit/directives/repeat.js';
36-
import { sendKeys, setUserAgent, setViewport } from '@web/test-runner-commands';
3737

3838
const RIGHT_BUTTON_SELECTOR = '.right-scroll';
3939
const LEFT_BUTTON_SELECTOR = '.left-scroll';
@@ -179,11 +179,11 @@ describe('TabsOverflow', () => {
179179
expect(finalLeft).to.be.lessThanOrEqual(initialLeft);
180180
});
181181

182-
xit('should scroll up to the last item and back in LTR', async () => {
183-
// setUserAgent is not currently supported by Playwright
184-
await setUserAgent(
185-
'Mozilla/5.0 (iPhone; CPU iPhone OS 12_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/15E148'
186-
);
182+
it('should scroll up to the last item and back in LTR', async () => {
183+
// TODO: run on iPhone as per https://github.com/adobe/spectrum-web-components/pull/4722
184+
// await setUserAgent(
185+
// 'Mozilla/5.0 (iPhone; CPU iPhone OS 12_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/15E148'
186+
// );
187187

188188
const el = await renderTabsOverflow({
189189
count: 8,
@@ -213,11 +213,11 @@ describe('TabsOverflow', () => {
213213
expect(tabsOverflow['overflowState'].canScrollRight).to.be.true;
214214
});
215215

216-
xit('should scroll up to the last item and back in RTL', async () => {
217-
// setUserAgent is not currently supported by Playwright
218-
await setUserAgent(
219-
'Mozilla/5.0 (iPhone; CPU iPhone OS 12_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/15E148'
220-
);
216+
it('should scroll up to the last item and back in RTL', async () => {
217+
// TODO: run on iPhone as per https://github.com/adobe/spectrum-web-components/pull/4722
218+
// await setUserAgent(
219+
// 'Mozilla/5.0 (iPhone; CPU iPhone OS 12_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/15E148'
220+
// );
221221

222222
const el = await renderTabsOverflow({
223223
count: 8,

0 commit comments

Comments
 (0)