Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[picker] "block" => "inline" mismatch? #1880

Open
Westbrook opened this issue May 18, 2023 · 2 comments
Open

[picker] "block" => "inline" mismatch? #1880

Westbrook opened this issue May 18, 2023 · 2 comments

Comments

@Westbrook
Copy link
Contributor

min-inline-size: calc(var(--spectrum-picker-minimum-width-multiplier) * var(--mod-picker-block-size, var(--spectrum-picker-block-size)));

Here we see min-inline-size set to block-size, is that expected?

@castastrophe
Copy link
Collaborator

@Westbrook I can double check but as I understand it, we're calculating the minimum width based on the size of the height * the multiplier. I believe that's on purpose however I do notice there's no override for min-inline-size either. Perhaps:

 min-inline-size: var(--mod-picker-inline-size, calc(var(--spectrum-picker-minimum-width-multiplier) * var(--mod-picker-block-size, var(--spectrum-picker-block-size)))); 

@castastrophe castastrophe changed the title "block" => "inline" mismatch? [picker] "block" => "inline" mismatch? Jul 12, 2023
@Westbrook
Copy link
Contributor Author

I think that makes sense. If the calculation is expected, a --mod-* value to ensure we still have full control over the width without altering the height should cover the bases.

Aside: oy, it is hard to think outloud in logical properties. 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants