Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composeAuditURL does not return the correct URL in some cases of domains with bot protection #237

Open
iuliag opened this issue May 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@iuliag
Copy link
Contributor

iuliag commented May 22, 2024

Description
composeAuditURL is used in both audit and import workers to return the URL to audit/import data for.
composeAuditURL does not return the correct URL in some cases of domains with bot protection, see example in slack thread below.

An empty response from RUM/ahrefs APIs doesn't always mean we're querying for the wrong URL. e.g. broken backlinks is expected sometimes to return empty, sometimes with broken backlinks. So we cannot just assume empty response => fallback to www, like the fix implemented in adobe/spacecat-audit-worker#248.

Expected behavior
composeAuditURL or a similar shared function should return a correct URL for those cases as well, and audits/imports should be updated to that version.

Additional context
See https://cq-dev.slack.com/archives/C05A45JBP9N/p1715068794711109

composeAuditURL:

async function composeAuditURL(url) {

@iuliag iuliag added the bug Something isn't working label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant