Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle audit enabling/disabling for DEFAULT_ORGANIZATION_ID sites #204

Open
iuliag opened this issue Apr 8, 2024 · 0 comments
Open
Assignees
Labels
question Further information is requested

Comments

@iuliag
Copy link
Contributor

iuliag commented Apr 8, 2024

Overview

How to handle audit enabling/disabling for DEFAULT_ORGANIZATION_ID sites

Details

https://cq-dev.slack.com/archives/C05A45JBP9N/p1712563602198179

https://github.com/adobe/spacecat-api-service/blob/main/src/controllers/trigger/common/trigger.js#L56

if (organization.getAuditConfig().auditsDisabled()) {

All created sites land in the default organization, if not otherwise set to a proper organization.
=> all audits (yes, there are exceptions that were not migrated to checking isAuditsDisabled common helper) for sites in the "default" organization are disabled, even if they are later set to enabled at site-level.

If we enable default organization for all audits, then we have to disable all audits for all sites created in the default org first, and re-enable manually for selected ones.

If we create a separate org for the site that revealed this issue to overcome the above, then that org is not DEFAULT_ORGANIZATION_ID and might break reporting about how many real validated customer orgs/sites vs DEFAULT_ORGANIZATION_ID.

Proposed Actions

and now?

@iuliag iuliag added the question Further information is requested label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants