SITES-24645: [Importer] Add validation check for jobId while creating…

… an import URL (#373) ## Related Issues [SITES-24645](https://jira.corp.adobe.com/browse/SITES-24645) We want to add a validation check for jobId in spacecat-shared while creating an import-url. We do not want an import-url entry in the DB without the jobId attribute.
adobe · Sep 19, 2024 · 0d16294 · 0d16294
1 parent 0362ba4
commit 0d16294
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 11 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/spacecat-shared-data-access/src/models/importer/import-url.js b/packages/spacecat-shared-data-access/src/models/importer/import-url.js
@@ -105,6 +105,10 @@ export const createImportUrl = (data) => {
     throw new Error(`Invalid Url: ${newState.url}`);
   }
 
+  if (!hasText(newState.jobId)) {
+    throw new Error(`Invalid Job ID: ${newState.jobId}`);
+  }
+
   if (!Object.values(ImportUrlStatus).includes(newState.status)) {
     throw new Error(`Invalid Import URL status: ${newState.status}`);
   }

diff --git a/packages/spacecat-shared-data-access/test/unit/models/importer/import-url.test.js b/packages/spacecat-shared-data-access/test/unit/models/importer/import-url.test.js
@@ -42,6 +42,10 @@ describe('ImportUrl Model tests', () => {
     it('throws an error if status is invalid', () => {
       expect(() => createImportUrl({ ...validImportUrlData, status: 'invalid' })).to.throw('Invalid Import URL status: invalid');
     });
+
+    it('throws an error if jobId is not a valid string', () => {
+      expect(() => createImportUrl({ ...validImportUrlData, jobId: null })).to.throw('Invalid Job ID: null');
+    });
   });
   describe('Import URL Functionality Tests', () => {
     let importUrl;

diff --git a/packages/spacecat-shared-data-access/test/unit/service/import-url/index.test.js b/packages/spacecat-shared-data-access/test/unit/service/import-url/index.test.js
@@ -69,6 +69,7 @@ describe('Import Url Tests', () => {
         const mockImportUrl = {
           id: 'test-id',
           status: 'RUNNING',
+          jobId: 'test-job-id',
           url: 'https://www.test.com',
         };
         await exportedFunctions.createNewImportUrl(mockImportUrl);
@@ -80,6 +81,7 @@ describe('Import Url Tests', () => {
       it('should update an existing importUrl with the correct status', async () => {
         const mockImportUrl = {
           id: 'test-id',
+          jobId: 'test-job-id',
           status: 'RUNNING',
           url: 'https://www.test.com',
         };
@@ -97,6 +99,7 @@ describe('Import Url Tests', () => {
       it('should throw an error when the importUrl does not exist', async () => {
         const mockImportUrl = {
           id: 'test-id',
+          jobId: 'test-job-id',
           status: 'RUNNING',
           url: 'https://www.test.com',
         };