From eade28ad97af9d4de35338195cfa2848dfc2b202 Mon Sep 17 00:00:00 2001 From: Damian Zehnder Date: Fri, 23 Aug 2024 13:40:32 +0200 Subject: [PATCH] fix: use promise allSettled instead of all --- package-lock.json | 21 --------------------- src/structured-data/handler.js | 5 ++++- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/package-lock.json b/package-lock.json index 679e7dad..ed6c0a83 100644 --- a/package-lock.json +++ b/package-lock.json @@ -4577,27 +4577,6 @@ "node": ">=16.0.0" } }, - "node_modules/@adobe/spacecat-shared-http-utils/node_modules/@aws-sdk/credential-provider-node/node_modules/@aws-sdk/credential-provider-node/node_modules/@aws-sdk/credential-provider-http": { - "version": "3.635.0", - "resolved": "https://registry.npmjs.org/@aws-sdk/credential-provider-http/-/credential-provider-http-3.635.0.tgz", - "integrity": "sha512-iJyRgEjOCQlBMXqtwPLIKYc7Bsc6nqjrZybdMDenPDa+kmLg7xh8LxHsu9088e+2/wtLicE34FsJJIfzu3L82g==", - "license": "Apache-2.0", - "peer": true, - "dependencies": { - "@aws-sdk/types": "3.609.0", - "@smithy/fetch-http-handler": "^3.2.4", - "@smithy/node-http-handler": "^3.1.4", - "@smithy/property-provider": "^3.1.3", - "@smithy/protocol-http": "^4.1.0", - "@smithy/smithy-client": "^3.2.0", - "@smithy/types": "^3.3.0", - "@smithy/util-stream": "^3.1.3", - "tslib": "^2.6.2" - }, - "engines": { - "node": ">=16.0.0" - } - }, "node_modules/@adobe/spacecat-shared-http-utils/node_modules/@aws-sdk/credential-provider-node/node_modules/@aws-sdk/credential-provider-node/node_modules/@aws-sdk/credential-provider-http": { "version": "3.635.0", "resolved": "https://registry.npmjs.org/@aws-sdk/credential-provider-http/-/credential-provider-http-3.635.0.tgz", diff --git a/src/structured-data/handler.js b/src/structured-data/handler.js index 619d137b..21484a15 100644 --- a/src/structured-data/handler.js +++ b/src/structured-data/handler.js @@ -96,7 +96,10 @@ export async function processStructuredData(baseURL, context, pages) { } }); - return Promise.all(urlInspectionResult); + const results = await Promise.allSettled(urlInspectionResult); + return results + .filter((result) => result.status === 'fulfilled') + .map((result) => result.value); } export async function structuredDataHandler(baseURL, context, site) {