From 55108c189aa223007f2c3412714c6dc985633909 Mon Sep 17 00:00:00 2001 From: Divyansh Pratap Date: Wed, 18 Sep 2024 18:34:00 +0530 Subject: [PATCH] fix: issues --- src/metatags/handler.js | 2 +- src/metatags/seo-checks.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/metatags/handler.js b/src/metatags/handler.js index dbc5b718..ede03e84 100644 --- a/src/metatags/handler.js +++ b/src/metatags/handler.js @@ -77,7 +77,7 @@ export default async function auditMetaTags(message, context) { for (const [pageUrl, pageTags] of Object.entries(extractedTags)) { seoChecks.performChecks(pageUrl, pageTags); } - seoChecks.organizeDetectedTags(); + seoChecks.finalChecks(); const detectedTags = seoChecks.getDetectedTags(); // Prepare Audit result const auditResult = { diff --git a/src/metatags/seo-checks.js b/src/metatags/seo-checks.js index 41dc78c6..90892b3e 100644 --- a/src/metatags/seo-checks.js +++ b/src/metatags/seo-checks.js @@ -73,8 +73,8 @@ class SeoChecks { if (tagContent === '') { this.detectedTags[tagName][EMPTY_TAGS] ??= { pageUrls: [] }; this.detectedTags[tagName][EMPTY_TAGS].pageUrls.push(url); - } else if (tagContent.length > TAG_LENGTHS[tagName].maxLength - || tagContent.length < TAG_LENGTHS[tagName].minLength) { + } else if (tagContent?.length > TAG_LENGTHS[tagName].maxLength + || tagContent?.length < TAG_LENGTHS[tagName].minLength) { this.detectedTags[tagName][LENGTH_CHECK_FAIL_TAGS] ??= {}; this.detectedTags[tagName][LENGTH_CHECK_FAIL_TAGS].url = url; this.detectedTags[tagName][LENGTH_CHECK_FAIL_TAGS].tagContent = tagContent;