From 54e084faa4544b999b83ba79304a75bb7ae46760 Mon Sep 17 00:00:00 2001 From: Robert Snow Date: Tue, 18 Mar 2025 08:43:14 +1100 Subject: [PATCH 1/7] debugging circleci --- .circleci/comment.js | 4 +- .circleci/config.yml | 267 ++++++++++---------- scripts/verdaccio-build-rac-rsp-tailwind.sh | 7 + 3 files changed, 141 insertions(+), 137 deletions(-) diff --git a/.circleci/comment.js b/.circleci/comment.js index 3fe410e9f4d..bcf5e30105c 100644 --- a/.circleci/comment.js +++ b/.circleci/comment.js @@ -11,7 +11,7 @@ async function run() { let pr; // If we aren't running on a PR commit, double check if this is a branch created for a fork. If so, we'll need to // comment the build link on the fork. - if (!process.env.CIRCLE_PULL_REQUEST) { + if (true) { try { const commit = await octokit.git.getCommit({ owner: 'adobe', @@ -41,7 +41,7 @@ async function run() { break; } } - } else if (process.env.CIRCLE_BRANCH === 'main') { + } else if (true) { //If it isn't a PR commit, then we are on main. Create a comment for the test app and docs build await octokit.repos.createCommitComment({ owner: 'adobe', diff --git a/.circleci/config.yml b/.circleci/config.yml index 9e182eb8fb8..82ab429784b 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -790,154 +790,151 @@ workflows: commit: jobs: - install - - install-16 - - install-17 - - install-19 - - test-ssr: - requires: - - install - - test: - requires: - - install - - test-ssr-16: - requires: - - install-16 - - test-16: - requires: - - install-16 - - test-ssr-17: - requires: - - install-17 - - test-17: - requires: - - install-17 - - test-19: - requires: - - install-19 - - test-ssr-19: - requires: - - install-19 - - test-esm: - requires: - - install - - lint: - requires: - - install - - ts-build-fork-point: - requires: - - install - filters: - branches: - ignore: main - - ts-build-branch: - requires: - - install - filters: - branches: - ignore: main - - ts-diff: - requires: - - ts-build-fork-point - - ts-build-branch - filters: - branches: - ignore: main - - typecheck-docs: - requires: - - install - - storybook: - requires: - - install - - storybook-16: - requires: - - install-16 - - storybook-17: - requires: - - install-17 - - storybook-19: - requires: - - install-19 - - storybook-s2: - requires: - - install - - docs: - requires: - - install + # - install-16 + # - install-17 + # - install-19 + # - test-ssr: + # requires: + # - install + # - test: + # requires: + # - install + # - test-ssr-16: + # requires: + # - install-16 + # - test-16: + # requires: + # - install-16 + # - test-ssr-17: + # requires: + # - install-17 + # - test-17: + # requires: + # - install-17 + # - test-19: + # requires: + # - install-19 + # - test-ssr-19: + # requires: + # - install-19 + # - test-esm: + # requires: + # - install + # - lint: + # requires: + # - install + # - ts-build-fork-point: + # requires: + # - install + # filters: + # branches: + # ignore: main + # - ts-build-branch: + # requires: + # - install + # filters: + # branches: + # ignore: main + # - ts-diff: + # requires: + # - ts-build-fork-point + # - ts-build-branch + # filters: + # branches: + # ignore: main + # - typecheck-docs: + # requires: + # - install + # - storybook: + # requires: + # - install + # - storybook-16: + # requires: + # - install-16 + # - storybook-17: + # requires: + # - install-17 + # - storybook-19: + # requires: + # - install-19 + # - storybook-s2: + # requires: + # - install + # - docs: + # requires: + # - install - verdaccio: - filters: - branches: - only: main requires: - install - - v-docs: - requires: - - verdaccio - - v-rsp-cra-18: - requires: - - verdaccio - - v-webpack-4: - requires: - - verdaccio - - v-nextjs: - requires: - - verdaccio + # - v-docs: + # requires: + # - verdaccio + # - v-rsp-cra-18: + # requires: + # - verdaccio + # - v-webpack-4: + # requires: + # - verdaccio + # - v-nextjs: + # requires: + # - verdaccio - v-rac-tailwind: requires: - verdaccio - v-rac-rsp-tailwind: requires: - verdaccio - - v-s2-parcel: - requires: - - verdaccio - - v-s2-webpack: - requires: - - verdaccio - - v-icon-builder: - requires: - - verdaccio - - v-publish-stats: - requires: - - verdaccio - - v-webpack-4 - - v-nextjs - - v-rsp-cra-18 - - deploy: - requires: - - lint - - test-ssr - - test - - test-ssr-16 - - test-16 - - test-ssr-17 - - test-17 - - test-esm - - storybook - - storybook-16 - - storybook-17 - - storybook-19 - - storybook-s2 - - docs + # - v-s2-parcel: + # requires: + # - verdaccio + # - v-s2-webpack: + # requires: + # - verdaccio + # - v-icon-builder: + # requires: + # - verdaccio + # - v-publish-stats: + # requires: + # - verdaccio + # - v-webpack-4 + # - v-nextjs + # - v-rsp-cra-18 + # - deploy: + # requires: + # - lint + # - test-ssr + # - test + # - test-ssr-16 + # - test-16 + # - test-ssr-17 + # - test-17 + # - test-esm + # - storybook + # - storybook-16 + # - storybook-17 + # - storybook-19 + # - storybook-s2 + # - docs - deploy-verdaccio: requires: - - v-docs - - v-rsp-cra-18 - - v-webpack-4 - - v-nextjs + # - v-docs + # - v-rsp-cra-18 + # - v-webpack-4 + # - v-nextjs - v-rac-tailwind - v-rac-rsp-tailwind - - v-s2-parcel - - v-s2-webpack - - v-icon-builder - - v-publish-stats - - comment: - name: comment-pr - filters: - branches: - ignore: main - requires: - - ts-diff - - deploy + # - v-s2-parcel + # - v-s2-webpack + # - v-icon-builder + # - v-publish-stats + # - comment: + # name: comment-pr + # filters: + # branches: + # ignore: main + # requires: + # - ts-diff + # - deploy - comment: name: comment-verdaccio requires: diff --git a/scripts/verdaccio-build-rac-rsp-tailwind.sh b/scripts/verdaccio-build-rac-rsp-tailwind.sh index 286df8a30f9..0aa6da22205 100755 --- a/scripts/verdaccio-build-rac-rsp-tailwind.sh +++ b/scripts/verdaccio-build-rac-rsp-tailwind.sh @@ -37,6 +37,13 @@ cd examples/rac-spectrum-tailwind yarn config set npmRegistryServer $registry yarn install --no-immutable yarn build --public-url ./ + +echo 'build RAC Spectrum Tailwind app done' + mv dist ../../$verdaccio_path/rac-spectrum-tailwind +echo 'move RAC Spectrum Tailwind app done' + netstat -tpln | awk -F'[[:space:]/:]+' '$5 == 4000 {print $(NF-2)}' | xargs kill + +echo 'verdaccio shutdown done' From 86ecf70c2b8bbca7cf2cbf8b85d064d099310c84 Mon Sep 17 00:00:00 2001 From: Robert Snow Date: Tue, 18 Mar 2025 08:58:02 +1100 Subject: [PATCH 2/7] remove overly large log --- scripts/verdaccio-build-icon-builder.sh | 2 -- scripts/verdaccio-build-nextjs.sh | 2 -- scripts/verdaccio-build-rac-rsp-tailwind.sh | 2 -- scripts/verdaccio-build-rac-tailwind.sh | 2 -- scripts/verdaccio-build-rsp-cra-18.sh | 2 -- scripts/verdaccio-build-s2-parcel.sh | 2 -- scripts/verdaccio-build-s2-webpack.sh | 2 -- scripts/verdaccio-build-webpack-4.sh | 2 -- scripts/verdaccio-build.sh | 2 -- 9 files changed, 18 deletions(-) diff --git a/scripts/verdaccio-build-icon-builder.sh b/scripts/verdaccio-build-icon-builder.sh index 0699a8ff678..9d2214e55b0 100755 --- a/scripts/verdaccio-build-icon-builder.sh +++ b/scripts/verdaccio-build-icon-builder.sh @@ -17,8 +17,6 @@ else echo "Verdaccio is NOT running on port 4000." fi -curl -s http://localhost:4000/@adobe/react-spectrum - yarn config set npmPublishRegistry --home $registry yarn config set npmRegistryServer --home $registry yarn config set npmAlwaysAuth --home false diff --git a/scripts/verdaccio-build-nextjs.sh b/scripts/verdaccio-build-nextjs.sh index 97a7c4cccdd..9ce48e27f3c 100755 --- a/scripts/verdaccio-build-nextjs.sh +++ b/scripts/verdaccio-build-nextjs.sh @@ -17,8 +17,6 @@ else echo "Verdaccio is NOT running on port 4000." fi -curl -s http://localhost:4000/@adobe/react-spectrum - yarn config set npmPublishRegistry --home $registry yarn config set npmRegistryServer --home $registry yarn config set npmAlwaysAuth --home false diff --git a/scripts/verdaccio-build-rac-rsp-tailwind.sh b/scripts/verdaccio-build-rac-rsp-tailwind.sh index 0aa6da22205..8694113df88 100755 --- a/scripts/verdaccio-build-rac-rsp-tailwind.sh +++ b/scripts/verdaccio-build-rac-rsp-tailwind.sh @@ -17,8 +17,6 @@ else echo "Verdaccio is NOT running on port 4000." fi -curl -s http://localhost:4000/@adobe/react-spectrum - yarn config set npmPublishRegistry --home $registry yarn config set npmRegistryServer --home $registry yarn config set npmAlwaysAuth --home false diff --git a/scripts/verdaccio-build-rac-tailwind.sh b/scripts/verdaccio-build-rac-tailwind.sh index 297e4d4738a..ca6bdba6dd4 100755 --- a/scripts/verdaccio-build-rac-tailwind.sh +++ b/scripts/verdaccio-build-rac-tailwind.sh @@ -17,8 +17,6 @@ else echo "Verdaccio is NOT running on port 4000." fi -curl -s http://localhost:4000/@adobe/react-spectrum - yarn config set npmPublishRegistry --home $registry yarn config set npmRegistryServer --home $registry yarn config set npmAlwaysAuth --home false diff --git a/scripts/verdaccio-build-rsp-cra-18.sh b/scripts/verdaccio-build-rsp-cra-18.sh index 8041f926a8f..8f3a414d85b 100755 --- a/scripts/verdaccio-build-rsp-cra-18.sh +++ b/scripts/verdaccio-build-rsp-cra-18.sh @@ -17,8 +17,6 @@ else echo "Verdaccio is NOT running on port 4000." fi -curl -s http://localhost:4000/@adobe/react-spectrum - yarn config set npmPublishRegistry --home $registry yarn config set npmRegistryServer --home $registry yarn config set npmAlwaysAuth --home false diff --git a/scripts/verdaccio-build-s2-parcel.sh b/scripts/verdaccio-build-s2-parcel.sh index 60025a91fd8..4219eec3a1a 100755 --- a/scripts/verdaccio-build-s2-parcel.sh +++ b/scripts/verdaccio-build-s2-parcel.sh @@ -17,8 +17,6 @@ else echo "Verdaccio is NOT running on port 4000." fi -curl -s http://localhost:4000/@adobe/react-spectrum - yarn config set npmPublishRegistry --home $registry yarn config set npmRegistryServer --home $registry yarn config set npmAlwaysAuth --home false diff --git a/scripts/verdaccio-build-s2-webpack.sh b/scripts/verdaccio-build-s2-webpack.sh index eaa13587b86..02eb483df19 100755 --- a/scripts/verdaccio-build-s2-webpack.sh +++ b/scripts/verdaccio-build-s2-webpack.sh @@ -17,8 +17,6 @@ else echo "Verdaccio is NOT running on port 4000." fi -curl -s http://localhost:4000/@adobe/react-spectrum - yarn config set npmPublishRegistry --home $registry yarn config set npmRegistryServer --home $registry yarn config set npmAlwaysAuth --home false diff --git a/scripts/verdaccio-build-webpack-4.sh b/scripts/verdaccio-build-webpack-4.sh index 3436764f6c1..ecbf4842e7a 100755 --- a/scripts/verdaccio-build-webpack-4.sh +++ b/scripts/verdaccio-build-webpack-4.sh @@ -17,8 +17,6 @@ else echo "Verdaccio is NOT running on port 4000." fi -curl -s http://localhost:4000/@adobe/react-spectrum - yarn config set npmPublishRegistry --home $registry yarn config set npmRegistryServer --home $registry yarn config set npmAlwaysAuth --home false diff --git a/scripts/verdaccio-build.sh b/scripts/verdaccio-build.sh index d5a70a63e4a..78a4ba1171f 100755 --- a/scripts/verdaccio-build.sh +++ b/scripts/verdaccio-build.sh @@ -17,8 +17,6 @@ else echo "Verdaccio is NOT running on port 4000." fi -curl -s http://localhost:4000/@adobe/react-spectrum - yarn config set npmPublishRegistry --home $registry yarn config set npmRegistryServer --home $registry yarn config set npmAlwaysAuth --home false From 5f98f71ee1bb2c8aaab386055c32da88bca06a4c Mon Sep 17 00:00:00 2001 From: Robert Snow Date: Tue, 18 Mar 2025 09:41:32 +1100 Subject: [PATCH 3/7] increase log verbosity --- examples/rac-spectrum-tailwind/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/rac-spectrum-tailwind/package.json b/examples/rac-spectrum-tailwind/package.json index 306f345637b..d79c9e079ff 100644 --- a/examples/rac-spectrum-tailwind/package.json +++ b/examples/rac-spectrum-tailwind/package.json @@ -4,7 +4,7 @@ "packageManager": "yarn@4.2.2", "scripts": { "start": "parcel src/index.html", - "build": "parcel build src/index.html", + "build": "parcel build src/index.html --log-level=\"verbose\"", "install-17": "yarn add -W react@^17 react-dom@^17" }, "dependencies": { From 961c6b7046fe1e0e5133b63fb356cd4d5701dcf8 Mon Sep 17 00:00:00 2001 From: Robert Snow Date: Tue, 18 Mar 2025 11:06:39 +1100 Subject: [PATCH 4/7] see if pinning the tailwind version fixes the issue --- examples/rac-spectrum-tailwind/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/rac-spectrum-tailwind/package.json b/examples/rac-spectrum-tailwind/package.json index d79c9e079ff..65b154e4c52 100644 --- a/examples/rac-spectrum-tailwind/package.json +++ b/examples/rac-spectrum-tailwind/package.json @@ -12,14 +12,14 @@ "@react-spectrum/provider": "^3.9.7", "@spectrum-icons/illustrations": "^3.6.3", "@spectrum-icons/workflow": "^4.2.12", - "@tailwindcss/postcss": "^4.0.0", + "@tailwindcss/postcss": "4.0.12", "parcel": "^2.13.0", "postcss": "^8.2.1", "react": "^18.2.0", "react-aria-components": "^1.6.0", "react-dom": "^18.2.0", "react-stately": "^3.23.0", - "tailwindcss": "^4.0.0", + "tailwindcss": "4.0.12", "tailwindcss-animate": "^1.0.5" }, "devDependencies": { From db3f94e0570ed41316a35d50af1d7c0fd1615022 Mon Sep 17 00:00:00 2001 From: Robert Snow Date: Tue, 18 Mar 2025 11:33:21 +1100 Subject: [PATCH 5/7] fix example build --- .circleci/comment.js | 4 +- .circleci/config.yml | 267 ++++++++++---------- examples/rac-spectrum-tailwind/package.json | 6 +- examples/rac-tailwind/package.json | 2 +- 4 files changed, 141 insertions(+), 138 deletions(-) diff --git a/.circleci/comment.js b/.circleci/comment.js index bcf5e30105c..3fe410e9f4d 100644 --- a/.circleci/comment.js +++ b/.circleci/comment.js @@ -11,7 +11,7 @@ async function run() { let pr; // If we aren't running on a PR commit, double check if this is a branch created for a fork. If so, we'll need to // comment the build link on the fork. - if (true) { + if (!process.env.CIRCLE_PULL_REQUEST) { try { const commit = await octokit.git.getCommit({ owner: 'adobe', @@ -41,7 +41,7 @@ async function run() { break; } } - } else if (true) { + } else if (process.env.CIRCLE_BRANCH === 'main') { //If it isn't a PR commit, then we are on main. Create a comment for the test app and docs build await octokit.repos.createCommitComment({ owner: 'adobe', diff --git a/.circleci/config.yml b/.circleci/config.yml index 82ab429784b..9e182eb8fb8 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -790,151 +790,154 @@ workflows: commit: jobs: - install - # - install-16 - # - install-17 - # - install-19 - # - test-ssr: - # requires: - # - install - # - test: - # requires: - # - install - # - test-ssr-16: - # requires: - # - install-16 - # - test-16: - # requires: - # - install-16 - # - test-ssr-17: - # requires: - # - install-17 - # - test-17: - # requires: - # - install-17 - # - test-19: - # requires: - # - install-19 - # - test-ssr-19: - # requires: - # - install-19 - # - test-esm: - # requires: - # - install - # - lint: - # requires: - # - install - # - ts-build-fork-point: - # requires: - # - install - # filters: - # branches: - # ignore: main - # - ts-build-branch: - # requires: - # - install - # filters: - # branches: - # ignore: main - # - ts-diff: - # requires: - # - ts-build-fork-point - # - ts-build-branch - # filters: - # branches: - # ignore: main - # - typecheck-docs: - # requires: - # - install - # - storybook: - # requires: - # - install - # - storybook-16: - # requires: - # - install-16 - # - storybook-17: - # requires: - # - install-17 - # - storybook-19: - # requires: - # - install-19 - # - storybook-s2: - # requires: - # - install - # - docs: - # requires: - # - install + - install-16 + - install-17 + - install-19 + - test-ssr: + requires: + - install + - test: + requires: + - install + - test-ssr-16: + requires: + - install-16 + - test-16: + requires: + - install-16 + - test-ssr-17: + requires: + - install-17 + - test-17: + requires: + - install-17 + - test-19: + requires: + - install-19 + - test-ssr-19: + requires: + - install-19 + - test-esm: + requires: + - install + - lint: + requires: + - install + - ts-build-fork-point: + requires: + - install + filters: + branches: + ignore: main + - ts-build-branch: + requires: + - install + filters: + branches: + ignore: main + - ts-diff: + requires: + - ts-build-fork-point + - ts-build-branch + filters: + branches: + ignore: main + - typecheck-docs: + requires: + - install + - storybook: + requires: + - install + - storybook-16: + requires: + - install-16 + - storybook-17: + requires: + - install-17 + - storybook-19: + requires: + - install-19 + - storybook-s2: + requires: + - install + - docs: + requires: + - install - verdaccio: + filters: + branches: + only: main requires: - install - # - v-docs: - # requires: - # - verdaccio - # - v-rsp-cra-18: - # requires: - # - verdaccio - # - v-webpack-4: - # requires: - # - verdaccio - # - v-nextjs: - # requires: - # - verdaccio + - v-docs: + requires: + - verdaccio + - v-rsp-cra-18: + requires: + - verdaccio + - v-webpack-4: + requires: + - verdaccio + - v-nextjs: + requires: + - verdaccio - v-rac-tailwind: requires: - verdaccio - v-rac-rsp-tailwind: requires: - verdaccio - # - v-s2-parcel: - # requires: - # - verdaccio - # - v-s2-webpack: - # requires: - # - verdaccio - # - v-icon-builder: - # requires: - # - verdaccio - # - v-publish-stats: - # requires: - # - verdaccio - # - v-webpack-4 - # - v-nextjs - # - v-rsp-cra-18 - # - deploy: - # requires: - # - lint - # - test-ssr - # - test - # - test-ssr-16 - # - test-16 - # - test-ssr-17 - # - test-17 - # - test-esm - # - storybook - # - storybook-16 - # - storybook-17 - # - storybook-19 - # - storybook-s2 - # - docs + - v-s2-parcel: + requires: + - verdaccio + - v-s2-webpack: + requires: + - verdaccio + - v-icon-builder: + requires: + - verdaccio + - v-publish-stats: + requires: + - verdaccio + - v-webpack-4 + - v-nextjs + - v-rsp-cra-18 + - deploy: + requires: + - lint + - test-ssr + - test + - test-ssr-16 + - test-16 + - test-ssr-17 + - test-17 + - test-esm + - storybook + - storybook-16 + - storybook-17 + - storybook-19 + - storybook-s2 + - docs - deploy-verdaccio: requires: - # - v-docs - # - v-rsp-cra-18 - # - v-webpack-4 - # - v-nextjs + - v-docs + - v-rsp-cra-18 + - v-webpack-4 + - v-nextjs - v-rac-tailwind - v-rac-rsp-tailwind - # - v-s2-parcel - # - v-s2-webpack - # - v-icon-builder - # - v-publish-stats - # - comment: - # name: comment-pr - # filters: - # branches: - # ignore: main - # requires: - # - ts-diff - # - deploy + - v-s2-parcel + - v-s2-webpack + - v-icon-builder + - v-publish-stats + - comment: + name: comment-pr + filters: + branches: + ignore: main + requires: + - ts-diff + - deploy - comment: name: comment-verdaccio requires: diff --git a/examples/rac-spectrum-tailwind/package.json b/examples/rac-spectrum-tailwind/package.json index 65b154e4c52..afb53f681ae 100644 --- a/examples/rac-spectrum-tailwind/package.json +++ b/examples/rac-spectrum-tailwind/package.json @@ -4,7 +4,7 @@ "packageManager": "yarn@4.2.2", "scripts": { "start": "parcel src/index.html", - "build": "parcel build src/index.html --log-level=\"verbose\"", + "build": "PARCEL_WORKER_BACKEND=process parcel build src/index.html", "install-17": "yarn add -W react@^17 react-dom@^17" }, "dependencies": { @@ -12,14 +12,14 @@ "@react-spectrum/provider": "^3.9.7", "@spectrum-icons/illustrations": "^3.6.3", "@spectrum-icons/workflow": "^4.2.12", - "@tailwindcss/postcss": "4.0.12", + "@tailwindcss/postcss": "^4.0.0", "parcel": "^2.13.0", "postcss": "^8.2.1", "react": "^18.2.0", "react-aria-components": "^1.6.0", "react-dom": "^18.2.0", "react-stately": "^3.23.0", - "tailwindcss": "4.0.12", + "tailwindcss": "^4.0.0", "tailwindcss-animate": "^1.0.5" }, "devDependencies": { diff --git a/examples/rac-tailwind/package.json b/examples/rac-tailwind/package.json index dc4c1a444f0..e963681d038 100644 --- a/examples/rac-tailwind/package.json +++ b/examples/rac-tailwind/package.json @@ -4,7 +4,7 @@ "packageManager": "yarn@4.2.2", "scripts": { "start": "parcel src/index.html", - "build": "parcel build src/index.html", + "build": "PARCEL_WORKER_BACKEND=process parcel build src/index.html", "install-17": "yarn add -W react@^17 react-dom@^17" }, "dependencies": { From 3b3a974a8f9b396242731e7327bad14260e3d3da Mon Sep 17 00:00:00 2001 From: Robert Snow Date: Tue, 18 Mar 2025 11:36:12 +1100 Subject: [PATCH 6/7] turn on verdaccio --- .circleci/comment.js | 4 ++-- .circleci/config.yml | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.circleci/comment.js b/.circleci/comment.js index 3fe410e9f4d..bcf5e30105c 100644 --- a/.circleci/comment.js +++ b/.circleci/comment.js @@ -11,7 +11,7 @@ async function run() { let pr; // If we aren't running on a PR commit, double check if this is a branch created for a fork. If so, we'll need to // comment the build link on the fork. - if (!process.env.CIRCLE_PULL_REQUEST) { + if (true) { try { const commit = await octokit.git.getCommit({ owner: 'adobe', @@ -41,7 +41,7 @@ async function run() { break; } } - } else if (process.env.CIRCLE_BRANCH === 'main') { + } else if (true) { //If it isn't a PR commit, then we are on main. Create a comment for the test app and docs build await octokit.repos.createCommitComment({ owner: 'adobe', diff --git a/.circleci/config.yml b/.circleci/config.yml index 9e182eb8fb8..d19e693a016 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -864,9 +864,6 @@ workflows: requires: - install - verdaccio: - filters: - branches: - only: main requires: - install - v-docs: From aa5d82a40a1ca7940743b1b364296153cc172aba Mon Sep 17 00:00:00 2001 From: Robert Snow Date: Tue, 18 Mar 2025 12:06:11 +1100 Subject: [PATCH 7/7] Revert "turn on verdaccio" This reverts commit 3b3a974a8f9b396242731e7327bad14260e3d3da. --- .circleci/comment.js | 4 ++-- .circleci/config.yml | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.circleci/comment.js b/.circleci/comment.js index bcf5e30105c..3fe410e9f4d 100644 --- a/.circleci/comment.js +++ b/.circleci/comment.js @@ -11,7 +11,7 @@ async function run() { let pr; // If we aren't running on a PR commit, double check if this is a branch created for a fork. If so, we'll need to // comment the build link on the fork. - if (true) { + if (!process.env.CIRCLE_PULL_REQUEST) { try { const commit = await octokit.git.getCommit({ owner: 'adobe', @@ -41,7 +41,7 @@ async function run() { break; } } - } else if (true) { + } else if (process.env.CIRCLE_BRANCH === 'main') { //If it isn't a PR commit, then we are on main. Create a comment for the test app and docs build await octokit.repos.createCommitComment({ owner: 'adobe', diff --git a/.circleci/config.yml b/.circleci/config.yml index d19e693a016..9e182eb8fb8 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -864,6 +864,9 @@ workflows: requires: - install - verdaccio: + filters: + branches: + only: main requires: - install - v-docs: