Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto-reload on .html resources #2400

Open
davidnuescheler opened this issue Jul 24, 2024 · 1 comment
Open

auto-reload on .html resources #2400

davidnuescheler opened this issue Jul 24, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@davidnuescheler
Copy link
Contributor

currently it seems that instant auto reload of .js and .css doesn't work when working on .html. i don't think there is a downside of also supporting auto reload of changed resources for those cases.
@davidnuescheler davidnuescheler added the enhancement New feature or request label Jul 24, 2024
@davidnuescheler
Copy link
Contributor Author

it looks like we would need to add the injection of livereload.js for static .html resources as well, which seems to change the flow a little bit here:

helix-cli/src/server/HelixServer.js

Line 73 in 3485216

await sendFile(filePath, {

@tripodsan tripodsan reopened this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tripodsan @davidnuescheler