From f8dc094c29411b52b182cd5d424c0daea0602a31 Mon Sep 17 00:00:00 2001 From: Qiyun Dai Date: Thu, 29 Jun 2023 13:47:27 -0500 Subject: [PATCH] fix(untranslated-ckg-pills): metadata key fix & ckg pill altText logic fix --- express/scripts/ckg-link-list.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/express/scripts/ckg-link-list.js b/express/scripts/ckg-link-list.js index ce0c9e965..fd01c0027 100644 --- a/express/scripts/ckg-link-list.js +++ b/express/scripts/ckg-link-list.js @@ -59,7 +59,7 @@ async function fetchLinkList() { } function matchCKGResult(ckgData, pageData) { - const ckgMatch = pageData.ckgID === ckgData.ckgID; + const ckgMatch = pageData.ckgid === ckgData.ckgID; const pageDataTasks = pageData.tasks ?? pageData.templateTasks; const taskMatch = ckgData.tasks?.toLowerCase() === pageDataTasks?.toLowerCase(); const currentLocale = getLocale(window.location); @@ -150,15 +150,15 @@ async function updateLinkList(container, linkPill, list) { if (pillsMapping) { const alternateText = pillsMapping.find((row) => window.location.pathname === `${urlPrefix}${row['Express SEO URL']}` && d.ckgID === row['CKG Pill ID']); - - if (alternateText && alternateText[`${localeColumnString}`]) { + const hasAlternateTextForLocale = alternateText && alternateText[`${localeColumnString}`]; + if (hasAlternateTextForLocale) { displayText = alternateText[`${localeColumnString}`]; if (templatePageData) { templatePageData.altShortTitle = displayText; } } - hideUntranslatedPill = !displayText && locale !== 'us'; + hideUntranslatedPill = !hasAlternateTextForLocale && locale !== 'us'; } if (templatePageData) {