From 11d732770ae49e0c1a2cec2599dd4407dc22c118 Mon Sep 17 00:00:00 2001 From: Qiyun Dai Date: Mon, 26 Jun 2023 13:16:37 -0500 Subject: [PATCH] wrap linklist generation in condition to prevent script blocking error --- express/scripts/ckg-link-list.js | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/express/scripts/ckg-link-list.js b/express/scripts/ckg-link-list.js index b2f3b939e..0fdfe4209 100644 --- a/express/scripts/ckg-link-list.js +++ b/express/scripts/ckg-link-list.js @@ -254,24 +254,26 @@ async function lazyLoadSearchMarqueeLinklist() { if (searchMarquee) { const linkListContainer = searchMarquee.querySelector('.carousel-container > .carousel-platform'); - const linkListTemplate = linkListContainer.querySelector('p').cloneNode(true); + if (linkListContainer) { + const linkListTemplate = linkListContainer.querySelector('p').cloneNode(true); - const linkListData = []; + const linkListData = []; - if (window.linkLists && window.linkLists.ckgData && getMetadata('short-title')) { - window.linkLists.ckgData.forEach((row) => { - linkListData.push({ - childSibling: row['child-siblings'], - ckgID: row.ckgID, - shortTitle: getMetadata('short-title'), - tasks: row.parent, // task on the page - displayValue: row.displayValue, + if (window.linkLists && window.linkLists.ckgData && getMetadata('short-title')) { + window.linkLists.ckgData.forEach((row) => { + linkListData.push({ + childSibling: row['child-siblings'], + ckgID: row.ckgID, + shortTitle: getMetadata('short-title'), + tasks: row.parent, // task on the page + displayValue: row.displayValue, + }); }); - }); - } + } - await updateLinkList(linkListContainer, linkListTemplate, linkListData); - linkListContainer.parentElement.classList.add('appear'); + await updateLinkList(linkListContainer, linkListTemplate, linkListData); + linkListContainer.parentElement.classList.add('appear'); + } } }