Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code errors should break the build #625

Open
purplecabbage opened this issue Dec 13, 2022 · 1 comment
Open

Code errors should break the build #625

purplecabbage opened this issue Dec 13, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@purplecabbage
Copy link
Member

Invalid JS, like adding an extra : to your action code will cause aio app build to choke and output a verbose error message that a developer can use to fix their code. ✅

However, if I call a function that is not import/required or reassign a value to a const it will happily webpack it .. even though, come runtime, it will certainly crash ❌

To test, simply add this to an action and watch it happily build ...

  const num = 100
  num = num + 1
@purplecabbage purplecabbage added the enhancement New feature or request label Dec 13, 2022
@aiojbot
Copy link
Collaborator

aiojbot commented Jan 5, 2023

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-1935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants