Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add synchronous call to EventHub.shared.start() for use in testing #951

Open
kevinlind opened this issue Jul 18, 2023 · 0 comments
Open
Labels
task Item that can be completed as a standalone code change or is part of an epic.Used by issue templates

Comments

@kevinlind
Copy link
Contributor

Task description

Improve performance and stability of unit tests which make use of the EventHub by adding a synchronous call to EventHub.shared.start() to allow test cases ensure the EventHub has started before running tests.
The Edge extension's EdgePublicAPITests were failing because calls to registerEventListener were failing presumably because the EventHub wasn't fully started. Adding a sleep() call after calling start() resolves the issue, but getting a signal from the EventHub when start() completes is a better option. Searching the repos shows several extensions call EventHub.shared.start() from unit tests, though I'm not aware of over test failures.

Additional implementation details or code snippet(s)

No response

@kevinlind kevinlind added the task Item that can be completed as a standalone code change or is part of an epic.Used by issue templates label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Item that can be completed as a standalone code change or is part of an epic.Used by issue templates
Projects
None yet
Development

No branches or pull requests

1 participant