Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] expose ModelManagerConfiguration #93

Open
Giwayume opened this issue Jan 16, 2023 · 0 comments
Open

[feature] expose ModelManagerConfiguration #93

Giwayume opened this issue Jan 16, 2023 · 0 comments

Comments

@Giwayume
Copy link

Is your feature request related to a problem? Please describe.
Export ModelManagerConfiguration interface from ModelClient.ts to root import so end user may use it.

Describe the solution you'd like
Can't do this without hax:

import { ModelManagerConfiguration } from '@adobe/aem-spa-page-model-manager';
const config: ModelManagerConfiguration = {};
config.modelClient = whatever;
ModelManager.initialize(config);

Describe alternatives you've considered
I can workaround by using import { ModelManagerConfiguration } from '@adobe/aem-spa-page-model-manager/dist/ModelManager';, but importing anything directly from a dist folder is usually risky behavior as it is more prone to implementation change without notice or documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant