Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model property in container will clash with exported field 'model' via a Content Fragment Sling Model Exporter #142

Open
znikolovski opened this issue Nov 9, 2022 · 0 comments

Comments

@znikolovski
Copy link

in certain cases a content fragment component needs to be represented as a Container to allow for inter-paragraph parsys injection.

Having a reserved property called model in the Container Props means that a Content Fragment component won't be able to leverage and extend from the default Container implementation due the property 'model' already being reserved for the PageModel object - see: thttps://github.com/adobe/aem-react-editable-components/blob/f61655af0e95bd9de4bf4d5769028a7c0883347f/src/components/Container.tsx#L31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant