-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Better starter project for AEMaaCS #4
Comments
Hi @Tylopilus - glad to see your interest in this project and playing around with it!
While typescript is increasingly used a lot in large-scale projects, many devs don't need it in the beginning.
This has not been very clear in this project, and we will need to improve it.
That'd be a good enhancement. Created #5 to track this.
You're right, we'll need to revisit the rewriter-rules.
We are working on an enhancement of the SPA Remote Page (Next) component in AEM so that you only need to set the SPA URL once in the root (home) page, and all child pages should inherit from it (following the path in AEM).
This will be addressed in a WIP tutorial to be published in Experience League.
We will add examples for it to the tutorial as well. |
I have to think about this. At first I had some concerns but the more I think about it the overhead would be manageable. AEM CA-Configs for runtime and each Next-Deployment has it's host-url. This would then still work with preview-build-urls and easily changeable. Is there any plan to provide a simple way of deploying this to adobe runtime? For now I will stick with vercel and see what to adjust. But my main point was also that there should be at least one additional starter template. This one as a showcase including wknd-app and a bare bones starter. This one is nice but it's a lot to strip out if you want to build anything else than wknd. Another thing: For SSG there also needs to be a function to get all available routes for which I created a Feature-Request here: adobe/aem-react-editable-components#132 |
That's in the radar. However, we don't have a detailed plan as of today.
Good point. It was based on wknd because of the sample AEM content you can get from it. Without wknd content we might end up with a vanilla Next.js app just like the one you get from |
The starter should already be opinionated about the connection to AEM. So same envs as here + adobe react packages. Additionally i think it would be wise to introduce a new package which is a config-client. This client then can either handle the authentication based on a developer token or local auth token and could also be a wrapper for the adobe-headless-client and co |
After toying around with this project I can see a few downsides for basing a real project off of this project:
pages/api/getNextProps.js
is used forSo all these issues are currently not addressed within this repo. For faster adoption rate imho there should be a good starter provided that has all these points checked and then can be build on top of.
The text was updated successfully, but these errors were encountered: