Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent treatment of full-width component dialogs #2870

Open
HitmanInWis opened this issue Sep 25, 2024 · 1 comment
Open

Inconsistent treatment of full-width component dialogs #2870

HitmanInWis opened this issue Sep 25, 2024 · 1 comment

Comments

@HitmanInWis
Copy link

For the most part when you open a Core Component dialog, the fields are constrained to a fixed width, and if you use the widget to expand the dialog to full-width the component configuration fields stay neatly contained in the center within a fixed column.

There are a couple exceptions:

  1. Progress Bar config fields expand to about 3/4 screen width.

This is caused by the Progress Bar dialog using cq-RichText-FixedColumn-column, which is likely a copy/paste from the Text component dialog (the only other dialog that uses this) in order to give room for additional RTE content. Since Progress Bar has no RTE in its dialog, this setting should be removed to bring the dialog in line with other components.

  1. Content Fragment and Content Fragment List fields expand to full screen width.

This is caused by missing column wrappers for the fields within the tabs.

                            <columns
                                jcr:primaryType="nt:unstructured"
                                sling:resourceType="granite/ui/components/coral/foundation/fixedcolumns"
                                margin="{Boolean}true">
                                <items jcr:primaryType="nt:unstructured">

Ideally these items are cleaned up for reasons of:

  • authoring consistency
  • providing good patterns for developers to follow
  • preventing these inconsistent dialog patterns from being accidentally copy/pasted to future Core Components
@juw177
Copy link

juw177 commented Sep 28, 2024

Also, what is the point of the full screen function when the fields can't expand? Any pathfield that is more than 4 levels deep is cropped and authors need to click on the field and move the cursor to the end to see which page it is pointing to.

If this is being looked at, please address this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants