Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdaptiveImageServlet should not stream binaries #2853

Open
joerghoh opened this issue Sep 6, 2024 · 1 comment · May be fixed by #2871
Open

AdaptiveImageServlet should not stream binaries #2853

joerghoh opened this issue Sep 6, 2024 · 1 comment · May be fixed by #2871

Comments

@joerghoh
Copy link
Contributor

joerghoh commented Sep 6, 2024

Feature Request

When possible the AdaptiveImageServlet should not stream binaries through the JVM; there are a number of cases where the asset binary is read from the blobstore and then streamed as-is to the requester. IF the Blobstore supports the download of the binary directly (see Direct Binary Access) this feature should be used instead.

As in AEM CS the streaming of binaries through the JVM is an antipattern, we should implement this feature here as well. It will be transparent for endusers, as this feature requests adapts the behaviour of the AdaptiveImageServlet to that behavior used by the AEM CS ootb asset download.

Describe the solution you'd like
Implement the approach described in the above Oak doc.

Are there alternatives?
nope

Documentation

@joerghoh
Copy link
Contributor Author

joerghoh commented Sep 6, 2024

Dependency to wcm-io/io.wcm.testing.aem-mock#50 because the AEM Mocks do not provide sufficient support to adapt the existing test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant