Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code smells in CIF code #947

Open
pithayx opened this issue Aug 5, 2022 · 2 comments
Open

Code smells in CIF code #947

pithayx opened this issue Aug 5, 2022 · 2 comments

Comments

@pithayx
Copy link

pithayx commented Aug 5, 2022

Expected Behavior - No Code Smells in AEMaaCS code scan.

Actual Behavior - Getting following code smell in the scan report -

cif-components-library:core-cif-components-all:2.0.0: Inclusion of both /etc/packages/adobe/aem650/core-cif-components-apps-2.0.0.zip/jcr:content and /apps/core in the same package violates the separation of immutable and mutable paths in the same package. : ImmutableMutableMixedPackage : https://www.adobe.com/go/aem_cmcq_immutablemutablemixe_en

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version: AEMaaCS 2022.7.8085.20220725T140323Z, CIF version :2.0.0

Sample Code that illustrates the problem

Logs taken while reproducing problem

@buuhuu
Copy link
Contributor

buuhuu commented Oct 11, 2022

Hey @pithayx, can you please add steps to reproduce this issue?

Did you try to add the CIF sources to your cloud manager project? If so this is usually not the recommended approach. We provide binary distribution packages of CIF that you can embed as dependencies into your project.

@pithayx
Copy link
Author

pithayx commented Oct 12, 2022

@buuhuu We have embeded the package as dependency in our project. This error is reported when the code is deployed as a part of AEMaaCS Cloud Manager pipelines in the code scan report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants