fix: throw if no price range on product or variant

Author: dylandepass

src/content/adobe-commerce.js

@@ -57,7 +57,9 @@ async function fetchProduct(sku, config) {
     const product = productAdapter(config, productData);
     return product;
   } catch (e) {
-    console.error('failed to parse product: ', e);
+    if (e.response) {
+      throw errorWithResponse(e.response.status, e.message);
+    }
     throw errorWithResponse(500, 'failed to parse product response');
   }
 }
@@ -98,7 +100,9 @@ async function fetchVariants(sku, config) {
     const { variants } = json?.data?.variants ?? {};
     return variantsAdapter(config, variants);
   } catch (e) {
-    console.error('failed to parse variants: ', e);
+    if (e.response) {
+      throw errorWithResponse(e.response.status, e.message);
+    }
     throw errorWithResponse(500, 'failed to parse variants response');
   }
 }
@@ -143,6 +147,9 @@ async function lookupProductSKU(urlkey, config) {
     return product.sku;
   } catch (e) {
     console.error('failed to parse product sku: ', e);
+    if (e.response) {
+      throw errorWithResponse(e.response.status, e.message);
+    }
     throw errorWithResponse(500, 'failed to parse product sku response');
   }
 }

src/content/queries/cs-product.js

@@ -10,7 +10,7 @@
  * governing permissions and limitations under the License.
  */
 
-import { forceImagesHTTPS } from '../../utils/http.js';
+import { errorWithResponse, forceImagesHTTPS } from '../../utils/http.js';
 import { gql, parseRating, parseSpecialToDate } from '../../utils/product.js';
 
 /**
@@ -91,6 +91,10 @@ export const adapter = (config, productData) => {
     } : null,
   };
 
+  if (!minPrice && !maxPrice) {
+    throw errorWithResponse(400, 'no product price range found');
+  }
+
   if (config.attributeOverrides?.product) {
     Object.entries(config.attributeOverrides.product).forEach(([key, value]) => {
       product.attributeMap[key] = product.attributeMap[value] ?? product[key];

src/content/queries/cs-variants.js

@@ -10,7 +10,7 @@
  * governing permissions and limitations under the License.
  */
 
-import { forceImagesHTTPS } from '../../utils/http.js';
+import { errorWithResponse, forceImagesHTTPS } from '../../utils/http.js';
 import { gql, parseRating, parseSpecialToDate } from '../../utils/product.js';
 
 /**
@@ -37,22 +37,26 @@ export const adapter = (config, variants) => variants.map(({ selections, product
     prices: {
       regular: {
         // TODO: determine whether to use min or max
-        amount: minPrice.regular.amount.value,
-        currency: minPrice.regular.amount.currency,
-        maximumAmount: maxPrice.regular.amount.value,
-        minimumAmount: minPrice.regular.amount.value,
+        amount: minPrice?.regular.amount.value,
+        currency: minPrice?.regular.amount.currency,
+        maximumAmount: maxPrice?.regular.amount.value,
+        minimumAmount: minPrice?.regular.amount.value,
       },
       final: {
         // TODO: determine whether to use min or max
-        amount: minPrice.final.amount.value,
-        currency: minPrice.final.amount.currency,
-        maximumAmount: maxPrice.final.amount.value,
-        minimumAmount: minPrice.final.amount.value,
+        amount: minPrice?.final.amount.value,
+        currency: minPrice?.final.amount.currency,
+        maximumAmount: maxPrice?.final.amount.value,
+        minimumAmount: minPrice?.final.amount.value,
       },
     },
     selections: (selections ?? []).sort(),
   };
 
+  if (!minPrice && !maxPrice) {
+    throw errorWithResponse(400, 'no variant price range found');
+  }
+
   if (config.attributeOverrides?.variant) {
     Object.entries(config.attributeOverrides.variant).forEach(([key, value]) => {
       variant.attributeMap[key] = variant.attributeMap[value] ?? variant[key];