fix: test and update

Author: dylandepass

src/catalog/update.js

@@ -57,25 +57,30 @@ export async function handleProductSaveRequest(ctx, config, request) {
     const product = await putProduct(ctx, config, requestBody);
     const products = [product];
 
-    const { base: _, ...otherPatterns } = config.confEnvMap[config.env];
+    const { base: _ = undefined, ...otherPatterns } = (config.env in config.confEnvMap)
+      ? config.confEnvMap[config.env]
+      : {};
     const matchedPathPatterns = Object.keys(otherPatterns);
 
-    for (const purgeProduct of products) {
-      for (const pattern of matchedPathPatterns) {
-        let path = pattern.replace('{{sku}}', purgeProduct.sku);
+    if (matchedPathPatterns.length !== 0) {
+      for (const purgeProduct of products) {
+        for (const pattern of matchedPathPatterns) {
+          let path = pattern.replace('{{sku}}', purgeProduct.sku);
 
-        if (path.includes('{{urlkey}}') && purgeProduct.urlKey) {
-          path = path.replace('{{urlkey}}', purgeProduct.urlKey);
-        }
+          if (path.includes('{{urlkey}}') && purgeProduct.urlKey) {
+            path = path.replace('{{urlkey}}', purgeProduct.urlKey);
+          }
 
-        for (const op of ['preview', 'live']) {
-          const response = await callAdmin(config, op, path, { method: 'post' });
-          if (!response.ok) {
-            return errorResponse(400, `failed to ${op} product`);
+          for (const op of ['preview', 'live']) {
+            const response = await callAdmin(config, op, path, { method: 'post' });
+            if (!response.ok) {
+              return errorResponse(400, `failed to ${op} product`);
+            }
           }
         }
       }
     }
+
     return new Response(undefined, { status: 201 });
   } catch (e) {
     if (e.response) {

test/catalog/update.test.js

@@ -106,24 +106,25 @@ describe('Product Save Tests', () => {
       assert.equal(callAdminStub.callCount, 4);
     });
 
-    it('should skip calling callAdmin when confMap has no matching keys', async () => {
+    it('should skip calling callAdmin when confMap has no matching env', async () => {
       const config = {
         sku: '1234',
         confEnvMap: {
-          'other-env': {
+          prod: {
+            base: { },
             '/path/to/{{sku}}': { env: 'other-env' },
           },
         },
-        env: 'test',
+        env: 'dev',
       };
       const ctx = { log: { error: sinon.stub() } };
       const request = { json: sinon.stub().resolves({ sku: '1234' }) };
 
+      saveProductsStub.resolves();
       const response = await handleProductSaveRequest(ctx, config, request);
 
-      assert.equal(response.status, 201);
-      assert(saveProductsStub.calledOnce);
       assert(callAdminStub.notCalled);
+      assert.equal(response.status, 201);
     });
 
     it('should return error when callAdmin fails', async () => {