Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checks for /$reference?level=... #84

Open
mjacoby opened this issue Jan 16, 2025 · 1 comment
Open

Remove checks for /$reference?level=... #84

mjacoby opened this issue Jan 16, 2025 · 1 comment
Labels
API Issue related to API validation

Comments

@mjacoby
Copy link

mjacoby commented Jan 16, 2025

Currently there are checks testing with content modifier reference in combination with level, e.g.

/shells/d3d3LmV4YW1wbGUuY29tL2lkcy9hYXMvODEzMl80MTAyXzgwNDJfNzU2MQ==/submodels/d3d3LmV4YW1wbGUuY29tL2lkcy9zbS84MTMyXzQxMDJfODA0Ml8xODYx/submodel-elements/$reference?level=core

Although this is allowed according to the specification it does not make any sense as the level modifier cannot influence the result.
According to the TF API this is a copy & paste error and the argument should have never been there.
This has been reflected by setting the level parameter as deprecated for calls to /$reference (as it could not be safely deleted without causing a breaking chance).

Therefore, I think these tests should be excluded in the future.

@otto-ifak
Copy link
Collaborator

Thank you, we will change this accordingly.

@juileetikekar juileetikekar added the API Issue related to API validation label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issue related to API validation
Projects
None yet
Development

No branches or pull requests

3 participants