Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pt.1] Remove EntityType #287

Closed
arnoweiss opened this issue Jul 11, 2023 · 1 comment
Closed

[Pt.1] Remove EntityType #287

arnoweiss opened this issue Jul 11, 2023 · 1 comment
Labels
accepted in principle acknowledged in work specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Milestone

Comments

@arnoweiss
Copy link

The Entity-SME currently requires to use the EntityType attribute which can bei either "CoManagedEntity" or "SelfManagedEntity", signifying whether the referred Asset has its own AAS.

image

Here's the issue:

Someone referring to an asset (for instance in a BOM) will not always know if the referred Asset has an AAS or not. There's no way to be sure that an Asset has no AAS. That means everyone modeling an Entity is forced to make a definitive statement which (in most cases) can not be made definitively.

@BirgitBoss
Copy link
Collaborator

BirgitBoss commented Oct 10, 2023

This is true. But if you choose CoManagedEntity you need to provide the information of the Entity within the submodel itself by adding corresponding statements. But it was not yet discussed what happens if the information for the entity is handled in a different submodel.

Discussion 2023-11-23 in Workstream AAS:
Alternatives:

  • set entityType to optional
  • extend enum with value "UNKNOWN"
  • adjust description of enum values EntityType
  • set attribute entityType to deprecated

to be considered:
Constraint AASd-014: Either the attribute globalAssetId or specificAssetId of an Entity must be set if Entity/entityType is set to "SelfManagedEntity". Otherwise, they do not exist.

Two options in case of CoManagedEntity:

  • in the BOM containing this Entity-Element via statements
  • in another Submodel of the same AAS
    - as part of the Technical Data of the overall asset
    - special submodel but it cannot be the technical data submodel
    - a statement can be used with a ReferenceElement that gives information where to find this information

Decision:
make entityType optional

  • Change Constraint to:
    Constraint AASd-014: Either the attribute globalAssetId or specificAssetId of an Entity must be set if Entity/entityType is set to "SelfManagedEntity".

@BirgitBoss BirgitBoss added the specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally label Oct 10, 2023
@BirgitBoss BirgitBoss added the requires workstream approval strategic decision proposal needs to be prepared in TF spec team label Nov 16, 2023
@BirgitBoss BirgitBoss added the accepted accepted in principle to be fixed label Nov 23, 2023
@BirgitBoss BirgitBoss added accepted in principle acknowledged in work and removed accepted accepted in principle to be fixed requires workstream approval strategic decision proposal needs to be prepared in TF spec team labels Dec 12, 2023
@BirgitBoss BirgitBoss added this to the V3.1 milestone Dec 14, 2023
BirgitBoss added a commit that referenced this issue Dec 15, 2023
@BirgitBoss BirgitBoss linked a pull request Dec 15, 2023 that will close this issue
BirgitBoss added a commit that referenced this issue Jan 29, 2024
* * (Editorial) MultiLanguageNameType inconsistent description, maxLength=128 (schemata were correct) ([#313](#313))
* (Editorial) HasKind/kind explanataroy text: use template, not type ([#313](#313))
* (Editorial) DataTypeDefXsd links now correctly to xmlschema11-2, not to xsd V1.1 ([#312](#312))
+ minor editorial changes

* New value "Role" in Enumeration AssetKind (#294)

* add new value "AssetKind" enumeration "Role"  #294
Change PathType to allow not only file:  #299

* Identifier: change length from 2000 to 2024 characters #299

* allow hyphens in idShort of Referables #295

* make Entity/entityType optional #287

* editorial change, add missing link to issue #295

* Update Constraint AASd-014 (part 2 of #287)

* EmbeddedDataSpecification/dataSpecification now mandatory #296

* Update Change Appendix w.r.t. EmbeddedDataSpecifcation/dataSpecification (now mandatory) #296

* #296 update Changes Section

* Editorial changes
#313

* semanticId of specificAssetId with name "globalAssetId"
#298

* Correct AASd-002

see #295 
for backward compatibility reasons idShort can end with an underscore. Additionally also 1 char idShorts are allowed.

* path .Specification.pdf

remove \

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted in principle acknowledged in work specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants