Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery-Lookup not consistantly specified in Part 2 and OpenAPI spec #301

Closed
ChrisKoerber opened this issue Jul 25, 2024 · 4 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@ChrisKoerber
Copy link

What happens?

Current spec Part 2 v3.0.2 specifies the input parameter assetIds for operation GetAllAssetAdministrationShellIdsByAssetLink as mandatory whereas the OpenAPI spec declares it as optional.

image
image

https://app.swaggerhub.com/apis/Plattform_i40/DiscoveryServiceSpecification/V3.0.2_SSP-001#/Asset%20Administration%20Shell%20Basic%20Discovery%20API/GetAllAssetLinksById

Why is this wrong?

The input param can either be optional or mandatory.

How should it be fixed?

I assume it should be optional, because the existence of pagination (limit and cursor params) in this operation indicates the possibility of a bigger returned result set. Also current BaSyx Web UI calls the Discovery without any assetId.

If so (pls verify), the Part 2 spec has to be change to
assetIds: mand. no, Card. 1..*

@ChrisKoerber ChrisKoerber added the bug Something isn't working label Jul 25, 2024
@ChrisKoerber
Copy link
Author

Similarity with bug #298

@sebbader-sap
Copy link
Contributor

Fix is also included in V3.0.3

@BirgitBoss
Copy link
Collaborator

@sebbader-sap: Issue can be closed now, no?

@sebbader-sap
Copy link
Contributor

Fix has been provided, therefore closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants