Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual input validation #17

Closed
marcoraddatz opened this issue Oct 22, 2024 · 3 comments · Fixed by #18
Closed

Add visual input validation #17

marcoraddatz opened this issue Oct 22, 2024 · 3 comments · Fixed by #18
Labels
bug Something isn't working

Comments

@marcoraddatz
Copy link

Right now, the inputs are validated, but it's not clear, why the "save" button is disabled. I think it might be a good and relatively easy feature to show validation errors (e.g. "PIN is not a number", "APN is required", etc.).

Also, it might be good to visually highlight the required inputs with an asterisks.

CleanShot 2024-10-22 at 18 21 42

@adlerre adlerre added the bug Something isn't working label Oct 22, 2024
@adlerre adlerre linked a pull request Oct 22, 2024 that will close this issue
@adlerre
Copy link
Owner

adlerre commented Oct 22, 2024

It sounds a little bit weird, but want save some space and don't use error descriptions.
The UI needs currently 140k and the partition size is only 196k.
But now required fields marked directly.

@marcoraddatz
Copy link
Author

marcoraddatz commented Oct 22, 2024

Can understand that. What about using HTMX instead of Angular? From my experience, this would shrink the size to less than 100k.

Here's an example with inline validation.

@adlerre
Copy link
Owner

adlerre commented Oct 22, 2024

Because i‘m love Angular.
Was der Bauer nicht kennt… 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants