New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I found the getLastBestLocation() in GingerbreadLastLocationFinder and LegacyLastLocationFinder has different implemention #7

Open

GoogleCodeExporter opened this issue Dec 16, 2015 · 1 comment

Labels

auto-migrated Priority-Medium Type-Defect

GoogleCodeExporter commented Dec 16, 2015

I found the implemention in these two files is different, but I can't 
understand why. 
I think the LegacyLastLocationFinder's implemention is not correct, But the 
GingerbreadLastLocationFinder's implemention is correct.
Thanks for your sharing of this project, It helps me a lot

Original issue reported on code.google.com by [email protected] on 6 Sep 2011 at 8:40

The text was updated successfully, but these errors were encountered:

Author

GoogleCodeExporter commented Dec 16, 2015

Well if you see the following line in getLastBestLocation(), it differs between 
the two:

    if (locationListener != null && (bestTime > minTime || bestAccuracy > minDistance))

The correct line in LegacyLastLocationFinder should be:

    if (locationListener != null && (bestTime < minTime || bestAccuracy > minDistance)) 

Pretty grave error

Original comment by [email protected] on 18 Jun 2014 at 8:07

GoogleCodeExporter added Priority-Medium Type-Defect auto-migrated labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment