[Feature Request-UNTESTED] Add INITIAL support for configurable (RSA) key sizes (2048, 3072, 4096) #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's Encrypt defaults to a key size of 2048 but 3072 and 4096 can now be used. Signed-off-by: Odin Vex <[email protected]>
Signed-off-by: Odin Vex <[email protected]>
|
WARNING: ANY |
OdinVex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: Let's Encrypt states they support
2048,3072,4096bit keys for RSA and it's becoming more common to use something greater than2048. Let's Encrypt defaults to a key size of2048but3072and4096have been supported for quite a while.Notes:
key_size: 2048is the default if not specified. Enumeration supports2048,3072,4096.Concerns: I don't have a setup for compiling a container for GitHub. This is untested. I do not know if specifying
--rsa-key-sizewill interfere with non-RSA certs.Fixes: #862.