-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What about supporting browsers without support of flexbox? #2
Comments
I think you could also remove use of
|
@nicooprat You're right. We are working on supporting older browsers via fallbacks. At first we planned to make it work with modern browsers. My question is (I did not try) if I can calculate heights of column cells. I guess table cells have same heights in one row which breaks the main logic of bricklayer. |
Right, didn't think of that. All columns have the same height, but it may exist a way to get their "natural" height (without calculating the sum of all of their children heights): Here's what the Chrome console indicates. Height is 680px but it looks like there's an intrinsic padding-bottom added. Couldn't find a way to calculate its value however... |
This strange padding is because of Calculating sum of children heights is the first idea I had, but sounds "heavy" when you think of loads of items in a column. We already want a very simple implementation. If you find a way to get natural height with minimal calculation please let us know or PR would be more awesome :) |
Seems not possible with table cells. But a workaround to get a column "natural" height without too much computation could be to compare the column |
Just a short note: please don't forget the new Edge Browser on Windows 10 and Windows 10 Mobile. At the moment Bricklayer does not work on Edge. |
@zippex is right, support on Windows 10 would be nice. |
Should we support browsers with no support of flexbox? Seems IE 9 and 8 does not have support for flexbox. Maybe we can fallback to
table
view with columns:@ademilter If you think supporting this is not required and will be overkill for its simplicity, we can just do not support.
PS. Calculating height of table columns may have problems and we can have problems with responsiveness.
The text was updated successfully, but these errors were encountered: