Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_globals._extensions form elements incorrectly rendered #2693

Closed
danielghost opened this issue Jan 9, 2023 · 1 comment
Closed

_globals._extensions form elements incorrectly rendered #2693

danielghost opened this issue Jan 9, 2023 · 1 comment
Labels
S: merged Completed, reviewed, and merged issues T: bug
Milestone

Comments

@danielghost
Copy link

In addition to #2691, the UI for child nodes are incorrectly displayed in the UI. _components and _extensions are nested under 'Accessibility' (_accessibility) rather than within their own nodes.

@taylortom taylortom added this to the v0.11.2 milestone Mar 23, 2023
simondate added a commit that referenced this issue Apr 25, 2023
@simondate
Copy link
Member

simondate commented Apr 25, 2023

I built upon @taylortom 's PR to add titles to the Components and Extensions attributes #2692

Note - I've hardcoded the titles. I tried to use origin.l10n.t('app.components') but it didn't compile, I guess this call is happening too late in the build cycle. I noticed the es.json file didn't have different terms for Components and Extensions and since this is meant to be a quick final fix for the final 0.X.X version I figured this will be acceptable

@taylortom taylortom mentioned this issue May 19, 2023
3 tasks
@taylortom taylortom added the S: merged Completed, reviewed, and merged issues label Aug 14, 2023
@taylortom taylortom changed the title _globals._extensions UI _globals._extensions form elements incorrectly rendered Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: merged Completed, reviewed, and merged issues T: bug
Projects
None yet
Development

No branches or pull requests

3 participants