refactor(datasets) Rename the private attributes in InnerDirichlet #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-narozniak
requested review from
jafermarq,
tanertopal and
danieljanes
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The naming of the class attributes resulting from the constructor paramters is not consistent.
The
alphais named_initial_alpha.Description
There are two _alpha attributes: initial alpha (which can be as simple as an int or float) and fully transformed alpha (proper shape for sampling from dirichlet).
The issue with inconsistent naming is trouble with saving this class in automatic manner to a config. The
_alphais save which isNonebut instead the_initial_alphashould be saved (to be albe to later on instantiate the object based on the config).Proposal
Rename:
_alphato_full_alpha_initial_alphato_alphaRelated PRs
This is needed for: #3659