Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable legacy client round logging #3221

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Apr 4, 2024

Issue

Description

The legacy client would display an empty round number, which could be confused with an error:

image

Related issues/PRs

N/A

Proposal

Explanation

Remove the logging line for legacy clients:

image

Checklist

  • Implement proposed change
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review April 4, 2024 20:04
@danieljanes danieljanes merged commit ccaeb70 into main Apr 5, 2024
28 checks passed
@danieljanes danieljanes deleted the disable-legacy-log-line branch April 5, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants