Fix divide_dataset in Federated Datasets #3192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When specifying fraction divisions that result in more than 2 divisions (parts of the divided dataset), the latter ones (3-rd, 4-th ...) are incorrect (due to the wrong index calculation). See #3188
Proposal
_check_division_config_correctness
before the division.Explanation
The
start_idx += end_idx
incorrectly does+=
, it should just be reassignedstart_idx = end_idx
as pointed out in the issue.Changelog entry