Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix divide_dataset in Federated Datasets #3192

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Conversation

adam-narozniak
Copy link
Contributor

Issue

When specifying fraction divisions that result in more than 2 divisions (parts of the divided dataset), the latter ones (3-rd, 4-th ...) are incorrect (due to the wrong index calculation). See #3188

Proposal

  • Fix the incorrect index calculation.
  • Extend the tests.
  • Apply the _check_division_config_correctness before the division.

Explanation

The start_idx += end_idx incorrectly does +=, it should just be reassigned start_idx = end_idx as pointed out in the issue.

Changelog entry

@jafermarq jafermarq merged commit 3759c0f into main Apr 3, 2024
34 checks passed
@jafermarq jafermarq deleted the fds-fix-divide-dataset branch April 3, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants