Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client auth interceptor #2946

Merged
merged 66 commits into from
Apr 24, 2024
Merged

Add client auth interceptor #2946

merged 66 commits into from
Apr 24, 2024

Conversation

danielnugraha
Copy link
Contributor

Issue

Description

Client interceptor is needed to enable client authentication.

Related issues/PRs

Proposal

Explanation

Add client interceptor that handles authentication, also create unit test to ensure client interceptor works as intended.

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

danielnugraha and others added 26 commits February 10, 2024 13:33
@danielnugraha
Add authentication state and test
d0d4ecd
@danielnugraha
Fix isort
91a2f18
@danielnugraha
Fix isort
db16c10
@danielnugraha
Run format.sh
28876bc
@danielnugraha
Add init.py
42a7d38
@danielnugraha
Fix line too long
8ec63c9
@danielnugraha
Fix line too long
8f04e25
@danielnugraha
Fix line too long
e8813fc
@danielnugraha
Fix subclassing
d9f3fb0
@danielnugraha
Fix subclassing
caf6695
@danielnugraha
Fix subclassing
fa217ae
@danielnugraha
Fix subclassing
6edddd6
@danielnugraha
Fix subclassing
8bb15a5
@jafermarq
fixes
c5bac4f
@danielnugraha
Fix state tests
c856b7c
@danielnugraha
Fix too broad exception
4758507
@danielnugraha
Add sqlite auth state test
e666da5
@danielnugraha
Merge remote-tracking branch 'origin' into add-auth-state
151a619
@danielnugraha
Merge branch 'add-auth-state' into add-client-auth-interceptor
6c8c346
@danielnugraha
Add client interceptor
e6421cb
@danielnugraha
Add mock servicer
3ee430a
@danielnugraha
Add unittest initializer
bcc481e
@danielnugraha
Integrate client interceptor
abe18a5
@danielnugraha
Integrate client interceptor
8d0b7c5
@danielnugraha
Add type:ignore to grpc primitives
328118e
@danielnugraha
Remove auth state and format client interceptor test
a63d664
@danieljanes danieljanes enabled auto-merge (squash) April 24, 2024 15:20
@danieljanes danieljanes merged commit 21bdc9c into main Apr 24, 2024
27 checks passed
@danieljanes danieljanes deleted the add-client-auth-interceptor branch April 24, 2024 15:23
mohammadnaseri pushed a commit that referenced this pull request May 2, 2024
@danielnugraha @jafermarq
@danieljanes @mohammadnaseri
Add client auth interceptor (#2946)
2ae1186 
Co-authored-by: jafermarq <[email protected]>
Co-authored-by: Daniel J. Beutel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammadnaseri mohammadnaseri mohammadnaseri left review comments

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielnugraha @danieljanes @mohammadnaseri @jafermarq