Skip to content

Commit

Permalink
feat(framework) Log a warning if the server fails to get initial para…
Browse files Browse the repository at this point in the history
…meters (#3461)

Co-authored-by: jafermarq <[email protected]>
  • Loading branch information
panh99 and jafermarq authored May 19, 2024
1 parent 7c98529 commit 938b087
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
9 changes: 8 additions & 1 deletion src/py/flwr/server/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,14 @@ def _get_initial_parameters(
get_parameters_res = random_client.get_parameters(
ins=ins, timeout=timeout, group_id=server_round
)
log(INFO, "Received initial parameters from one random client")
if get_parameters_res.status.code == Code.OK:
log(INFO, "Received initial parameters from one random client")
else:
log(
WARN,
"Failed to receive initial parameters from the client."
" Empty initial parameters will be used.",
)
return get_parameters_res.parameters


Expand Down
9 changes: 8 additions & 1 deletion src/py/flwr/server/workflow/default_workflows.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,14 @@ def default_init_params_workflow(driver: Driver, context: Context) -> None:
]
)
msg = list(messages)[0]
if msg.has_content():

if (
msg.has_content()
and compat._extract_status_from_recordset( # pylint: disable=W0212
"getparametersres", msg.content
).code
== Code.OK
):
log(INFO, "Received initial parameters from one random client")
paramsrecord = next(iter(msg.content.parameters_records.values()))
else:
Expand Down

0 comments on commit 938b087

Please sign in to comment.