Skip to content

Commit

Permalink
Remove UserWarning for provided Dataset
Browse files Browse the repository at this point in the history
  • Loading branch information
gubertoli authored Apr 4, 2024
1 parent 2090d86 commit 6f55f73
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions datasets/flwr_datasets/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def _instantiate_resplitter_if_needed(
return cast(Optional[Resplitter], resplitter)


def _check_if_dataset_tested(dataset: Union[str, Dataset]) -> None:
def _check_if_dataset_tested(dataset: Union[str, Dataset]):
"""Check if the dataset is in the narrowed down list of the tested datasets."""
if dataset not in tested_datasets and type(dataset) is str:
warnings.warn(
Expand Down Expand Up @@ -133,6 +133,7 @@ def divide_dataset(
>>> train_test = divide_dataset(dataset=partition, division=division)
>>> train, test = train_test["train"], train_test["test"]
"""
_check_division_config_correctness(division)
dataset_length = len(dataset)
ranges = _create_division_indices_ranges(dataset_length, division)
if isinstance(division, (list, tuple)):
Expand Down Expand Up @@ -162,15 +163,15 @@ def _create_division_indices_ranges(
for fraction in division:
end_idx += int(dataset_length * fraction)
ranges.append(range(start_idx, end_idx))
start_idx += end_idx
start_idx = end_idx
elif isinstance(division, dict):
ranges = []
start_idx = 0
end_idx = 0
for fraction in division.values():
end_idx += int(dataset_length * fraction)
ranges.append(range(start_idx, end_idx))
start_idx += end_idx
start_idx = end_idx
else:
TypeError(
f"The type of the `division` should be dict, "
Expand Down Expand Up @@ -274,6 +275,7 @@ def concatenate_divisions(
concatenated_divisions : Dataset
A dataset created as concatenation of the divisions from all partitions.
"""
_check_division_config_correctness(partition_division)
divisions = []
zero_len_divisions = 0
for partition_id in range(partitioner.num_partitions):
Expand Down

0 comments on commit 6f55f73

Please sign in to comment.