From 1a3ab482dfebcb1294892fca0b47ade9bf99d6c0 Mon Sep 17 00:00:00 2001 From: Charles Beauville Date: Tue, 24 Sep 2024 10:34:44 +0200 Subject: [PATCH] Fix check --- dev/update_version.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dev/update_version.py b/dev/update_version.py index d945e3198d67..3c9454a1feaf 100644 --- a/dev/update_version.py +++ b/dev/update_version.py @@ -2,6 +2,7 @@ import argparse import re +import sys from pathlib import Path @@ -55,6 +56,7 @@ def _get_next_version(curr_version, increment): def _update_versions(file_patterns, replace_strings, new_version, check): """Update the version strings in the specified files.""" + wrong = False for pattern in file_patterns: files = list(Path(__file__).parents[1].glob(pattern)) for file_path in files: @@ -68,12 +70,16 @@ def _update_versions(file_patterns, replace_strings, new_version, check): regex_pattern = re.compile(escaped_s) content = regex_pattern.sub(s.format(version=new_version), content) if content != original_content: + wrong = True if check: print(f"{file_path} would be updated") else: file_path.write_text(content) print(f"Updated {file_path}") + if wrong and check: + sys.exit("Some version haven't been updated.") + if __name__ == "__main__": parser = argparse.ArgumentParser(