Skip to content

Commit

Permalink
fix(framework:skip) Update the description of args for `flower-supern…
Browse files Browse the repository at this point in the history
…ode` and `flower-client-app` and fix the usage of `args.max_retries` (#3710)
  • Loading branch information
panh99 authored Jul 5, 2024
1 parent ac1297d commit 131edbb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/py/flwr/client/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ def _on_backoff(retry_state: RetryState) -> None:
retry_invoker = RetryInvoker(
wait_gen_factory=exponential,
recoverable_exceptions=connection_error_type,
max_tries=max_retries,
max_tries=max_retries + 1 if max_retries is not None else None,
max_time=max_wait_time,
on_giveup=lambda retry_state: (
log(
Expand Down
6 changes: 3 additions & 3 deletions src/py/flwr/client/supernode/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -345,16 +345,16 @@ def _parse_args_common(parser: argparse.ArgumentParser) -> None:
"--max-retries",
type=int,
default=None,
help="The maximum number of times the client will try to connect to the"
"server before giving up in case of a connection error. By default,"
help="The maximum number of times the client will try to reconnect to the"
"SuperLink before giving up in case of a connection error. By default,"
"it is set to None, meaning there is no limit to the number of tries.",
)
parser.add_argument(
"--max-wait-time",
type=float,
default=None,
help="The maximum duration before the client stops trying to"
"connect to the server in case of connection error. By default, it"
"connect to the SuperLink in case of connection error. By default, it"
"is set to None, meaning there is no limit to the total time.",
)
parser.add_argument(
Expand Down

0 comments on commit 131edbb

Please sign in to comment.