Skip to content
This repository has been archived by the owner on Jun 12, 2021. It is now read-only.

ITestOutputHelper does not work in constructors/dispose or Teardown() when test-class contains xbehave-Scenarios #565

Open
Jazzman82 opened this issue May 19, 2019 · 11 comments
Labels
bug Something isn't working
Milestone

Comments

@Jazzman82
Copy link

Is it possible to add the ITestOutputHelper to those artifacts? It always says that there is no active test-case, but it should be possible as constructor/dispose and Teardown are test-case specific.

@adamralph adamralph added the bug Something isn't working label May 19, 2019
@adamralph
Copy link
Owner

adamralph commented May 19, 2019

Hi @Jazzman82 thanks for raising this. I've successfully reproduced the problem.

The good news is that I currently have some work in progess which should fix this.

@Jazzman82
Copy link
Author

Cool! So I will switch to patience-mode ;)

@adamralph adamralph added this to the 2.4.1 milestone Jun 2, 2019
@redoz
Copy link
Contributor

redoz commented Apr 14, 2020

@adamralph Just ran into this myself, as I re-used a helper-method that writes to the ITestOutputHelper in a Teardown method, so I just wanted to check what the expectations are on this issue? Anything I can do to help out?

@Andras-Csanyi
Copy link

I have the same issue. Any progress on this?

@adamralph
Copy link
Owner

@SayusiAndo unfortunately I have had no time to work on this.

@Andras-Csanyi
Copy link

@adamralph No worries. I could solve it, unfortunately I had to drop xBehave.

@Eklange
Copy link

Eklange commented Nov 25, 2020

Any updates on this issue, would be great to be able to use ITestOutputHelper with xBehave

@adamralph
Copy link
Owner

I'm not aware of any progress since my last comment.

Anything I can do to help out?

@redoz PR's are always welcome. 🙂

@redoz
Copy link
Contributor

redoz commented Nov 26, 2020

@adamralph Is #566 on hold waiting for xunit3?

@adamralph
Copy link
Owner

adamralph commented Nov 26, 2020

Is #566 on hold waiting for xunit3?

@redoz no, it's not waiting for xunit3. It's something I started a while back, but didn't have time progress with any further.

That said, I'm not entirely sure if it's worth trying to get that all done (I'm not entirely sure where it's leading TBH) or whether it's worth just leaving xbehave 2.x as-is and waiting for xunit 3. Because xunit 2 was so different to xunit 1, xbehave 2 was a complete re-write, so it may be the same for xbehave 3.

@redoz
Copy link
Contributor

redoz commented Nov 26, 2020

@adamralph Yeah my impression was that doing significant work with xunit2 internals would be wasted effort as soon as xunit3 is released, so I'm looking for quick wins, and will see if the new version offers what I need before starting to extend it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants